From owner-freebsd-bugs@FreeBSD.ORG Mon Sep 13 08:34:02 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A8CB16A4CE; Mon, 13 Sep 2004 08:34:02 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 554E843D46; Mon, 13 Sep 2004 08:34:02 +0000 (GMT) (envelope-from dd@FreeBSD.org) Received: from freefall.freebsd.org (dd@localhost [127.0.0.1]) i8D8Y2TV032531; Mon, 13 Sep 2004 08:34:02 GMT (envelope-from dd@freefall.freebsd.org) Received: (from dd@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8D8Y2ls032527; Mon, 13 Sep 2004 08:34:02 GMT (envelope-from dd) Date: Mon, 13 Sep 2004 08:34:02 GMT From: Dima Dorfman Message-Id: <200409130834.i8D8Y2ls032527@freefall.freebsd.org> To: dan@obluda.cz, dd@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: bin/71662: [PATCH] cleanup of the usr.sbin/ifmcast code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2004 08:34:02 -0000 Synopsis: [PATCH] cleanup of the usr.sbin/ifmcast code State-Changed-From-To: open->closed State-Changed-By: dd State-Changed-When: Mon Sep 13 08:33:44 GMT 2004 State-Changed-Why: Committed, thanks! When you make changes like this, it's a good idea to see if you can clamp down the program to a higher WARNS level. In this case, the program compiles cleanly with WARNS=2 after your change, so I set that. Setting WARNS in the Makefile makes sure that future changes to the program don't cause more warnings. Since WARNS means that warnings will break the build, though, it's good to be able to test the change on more than one architecture to make sure you don't miss any platform-specific issues. http://www.freebsd.org/cgi/query-pr.cgi?pr=71662