From owner-cvs-all@FreeBSD.ORG Tue May 22 16:18:45 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C57A516A468; Tue, 22 May 2007 16:18:45 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 81F0F13C489; Tue, 22 May 2007 16:18:45 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l4MGFQp4060638; Tue, 22 May 2007 10:15:26 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 22 May 2007 10:15:26 -0600 (MDT) Message-Id: <20070522.101526.78768763.imp@bsdimp.com> To: rwatson@FreeBSD.org From: Warner Losh In-Reply-To: <20070522112825.U50138@fledge.watson.org> References: <200705192051.l4JKp0rF074703@repoman.freebsd.org> <20070522003856.GX21795@elvis.mu.org> <20070522112825.U50138@fledge.watson.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Tue, 22 May 2007 10:15:26 -0600 (MDT) Cc: cvs-src@FreeBSD.org, alfred@FreeBSD.org, andre@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2007 16:18:45 -0000 > On Mon, 21 May 2007, Alfred Perlstein wrote: > > > Is this the same bug that used to be in sendfile but got corrected some > > years back? > > Dunno, but it sounds like we really need a comprehensive set of edge-case > tests for sendfile. There are those that advocate writing a test case that fails, then fixing the code until the test case succeeds, then committing the test case to the test-bed at the same time the code is committed to the tree. With the test-case gating the code. This works well for some thing, but we can't do it universally since some test-cases would be only for 'rogue' hardware, which can't be automatically tested. Warner