Date: Fri, 1 Apr 2016 18:35:31 +0200 From: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com> To: =?UTF-8?Q?Gustau_P=C3=A9rez?= <gustau.perez@gmail.com> Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>, FreeBSD XEN <freebsd-xen@freebsd.org> Subject: Re: Porting the block-iscsi hotplug script Message-ID: <alpine.OSX.2.20.1604011827450.9476@mac> In-Reply-To: <56FA7E00.6030309@gmail.com> References: <553DEB97.5000300@entel.upc.edu> <56CB0057.1060509@gmail.com> <56CB041E.1020009@citrix.com> <56CB2D90.5080809@gmail.com> <56CB34BA.6060809@citrix.com> <56CC24BD.6050609@gmail.com> <56CC32E5.5010101@citrix.com> <56CC7637.3080408@gmail.com> <56CF5668.6090605@citrix.com> <56D0091F.80408@gmail.com> <56D02863.7040100@citrix.com> <56D03D95.9090509@gmail.com> <56D04E5F.8070901@citrix.com> <56D42A28.8050701@gmail.com> <56D434FC.8030905@citrix.com> <56D57110.2060406@gmail.com> <56D587D8.6030702@citrix.com> <56D590EA.609@gmail.com> <56D591BA.4020303@gmail.com> <56D5929F.7040001@citrix.com> <56D5C722.3080205@gmail.com> <56D6B68D.8080809@citrix.com> <56D7FEFE.9050000@gmail.com> <alpine.OSX.2.20.1603041055250.20397@mac> <56D97762.7000908@gmail.com> <alpine.OSX.2.20.1603041647160.22025@mac> <56E84043.4060602@gmail.com> <56EAA788.3020404@gmail.com> <alpine.OSX.2.20.1603221208230.24317@macbook-air-de-roger.local> <56FA7E00.6030309@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 29 Mar 2016, Gustau Pérez wrote: > > Hello, > > > > I've been on vacations last week and I'm trying to catch up with my email > > backlog, sorry for the delay in the reply. > > > > OTOH, George Dunlap from Citrix has posted the series that should enable > > hotplug scripts to work with HVM domains. I need to rebase my FreeBSD > > hotplug script support on top of it, so you can try it. George's series > > can be found at: > > > > http://lists.xenproject.org/archives/html/xen-devel/2016-03/msg02739.html > > > > I will try to rebase my work on top of this and provide you with a git > > branch so you can easily test it. > > > > Regarding your questions about the locking mechanism, I'm not that > > familiar with it, but I'm not sure why a lock array is need. AFAICT only > > one lock should be needed, that prevents multiple hotplug scripts from > > travessing the xenstore disk information at the same time. Please bring > > this question to xen-devel. > > > >> [1] http://pastebin.com/FhaQeuG1 > >> [2] http://pastebin.com/ZHWKRg5f > > LGTM :). You will have to formally submit this as patches when the hotplug > > work is committed to upstream Xen. > > > > Hi Roger, > > I've been checking the changes to eventually send them upstream and > there are a bits that I thinkg you would also need to commit upstream > before I can send mine. Those changes are in the sysutils/xen-tools port > (I see those signed patches in the files/ directory but I can't find > them in xenbits repo). > > I did the signed patch containing my changes [1], if you want to > check it. I could add your changes, but I fear I may miss something > along the way. All the FreeBSD hotplug patches are quite close to being committed upstream, AFAIK they have all been already acked, and unless something goes wrong they will make it into the next release (4.7). The only missing bits are the locking. ATM with my dummy disk hotplug script there's the risk of sharing the same image between guests in incompatible ways, but it's no worse that what we have right now. Probably early next week everything is going to be in the Xen repository, which means you could rebase your work on top of that and I will no longer be on the way of you adding a iSCSI hotplug script :). Roger.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.OSX.2.20.1604011827450.9476>