From owner-freebsd-ports@FreeBSD.ORG Tue Nov 15 22:06:45 2005 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 59DDC16A41F for ; Tue, 15 Nov 2005 22:06:45 +0000 (GMT) (envelope-from swhetzel@gmail.com) Received: from xproxy.gmail.com (xproxy.gmail.com [66.249.82.198]) by mx1.FreeBSD.org (Postfix) with ESMTP id 942EC43D4C for ; Tue, 15 Nov 2005 22:06:44 +0000 (GMT) (envelope-from swhetzel@gmail.com) Received: by xproxy.gmail.com with SMTP id s9so935079wxc for ; Tue, 15 Nov 2005 14:06:43 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=jjMqmGvw1leLLyI2ceMg9jKmJDwahjogMIKNyUss3pU6V6iNQjOHGvnToRDPw1mfzHz68RMaEIHZnmazpIdGkuqe4FikYV1OzqAIO1LcnlgBb33v8tAnQao5WVTMrBnY4IWqCD+soXQshppxuv/D++7HxzQE+c/aNyHHEOL+ZwM= Received: by 10.70.69.8 with SMTP id r8mr3263426wxa; Tue, 15 Nov 2005 13:40:51 -0800 (PST) Received: by 10.70.31.5 with HTTP; Tue, 15 Nov 2005 13:40:51 -0800 (PST) Message-ID: <790a9fff0511151340t461bcc64kcc58d0817af4795@mail.gmail.com> Date: Tue, 15 Nov 2005 15:40:51 -0600 From: Scot Hetzel To: "Michael C. Shultz" In-Reply-To: <200511151301.16549.ringworm01@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200511151154.32536.ringworm01@gmail.com> <790a9fff0511151300k51a95084sc8f97181d88e1022@mail.gmail.com> <200511151301.16549.ringworm01@gmail.com> Cc: Craig Boston , Jiawei Ye , freebsd-ports@freebsd.org Subject: Re: Why does security/amavisd-new depend on db3? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2005 22:06:45 -0000 > This would still be wrong: > > .if ${.CURDIR} =3D=3D /usr/ports/databases/p5-BerkleyDB > WITH_BDB_VER?=3D42 > .endif > No, it would be right because when the build for security/amavisd-new calls for the build of databases/p5-BerkleyDB, the WITH_BDB_VER variable is set in the environment for database/p5-BerkleyDB and cause the dependancy to be set on the correct version of Berkley DB port. > It is equivalent to: > > in pkgtools.conf: > MAKE_ARGS =3D { > 'databases/p5-BerkeleyDB' =3D> 'WITH_BDB_VER=3D42', > > in pm-020.conf > databases/p5-BerkeleyDB|WITH_BDB_VER=3D42| > It's similar, but not equivalent because when the security/amavisd-new then goes to record it's dependancies on the databases/p5-BerkleyDB port. Using portupgrade and portmanager, security/amavisd-new +CONTENT shows db3 as dependancy, were as the /etc/make.conf entry will show a +CONTENT dependacy on db42. > Maybe you mean to set it as a global > value ie. without the .if ${.CURDIR} =3D=3D /usr/ports/databases/p5-Berkl= eyDB > wrapper? If that were the case it would still have no effect on > security/amavisd-new where the incorrect dependency is being recorded, > see for yourself: > The incorrect dependency is being reported from databases/p5-BerkleyDB to the security/amavisd-new port. Which then records the incorrect dependancy in the +CONTENT file. By using the WITH_BDB_VER as either a global variable or using '.if ${.CURDIR} =3D=3D /usr/ports/database/p5-BerkleyDB' in /etc/make.conf will fix the dependancy for security/amavisd-new. Each time make is called the /etc/make.conf file is re-evaluated.=20 Since the security/amavisd-new port calls cd /usr/ports/database/p5-BerkleyDB ; make install (from bsd.port.mk), the /etc/make.conf file is re-evaluated, and WITH_BDB_VER is set. Scot -- DISCLAIMER: No electrons were mamed while sending this message. Only slightly bruised.