From owner-freebsd-eclipse@FreeBSD.ORG Tue Mar 20 18:31:11 2012 Return-Path: Delivered-To: freebsd-eclipse@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CEC661065670 for ; Tue, 20 Mar 2012 18:31:11 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com [209.85.210.54]) by mx1.freebsd.org (Postfix) with ESMTP id 939CE8FC15 for ; Tue, 20 Mar 2012 18:31:11 +0000 (UTC) Received: by dald2 with SMTP id d2so433893dal.13 for ; Tue, 20 Mar 2012 11:31:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-operating-system :organization:x-living-the-dream:x-pgp-fingerprint:x-pgp-key :user-agent:x-gm-message-state; bh=Uv8xYNONH2Xz9G0/GhbUsUiM0yI92aUEfwTjoSS0FZY=; b=Oo+owYESVOXjJYYTYk8fQRaTSKvmzzmXG2dPQP6nfdoRx+KXynW07p6pA2Kdlppa2o Pso46jh/8YjlW8RiBqzIVi6eCf6nms6qEKB+eV1mYnOaaY84FKy9ZgNS3hZhMvK11WWz 0K8g5vIv6akNfWTHdgMVx2Zzgr1jZ6sPzU9DsWiOJ3TgFDVuzLmq0/hNGnNnrNKkrasC yqxm0uppE1ug6vVI1xAOFiL9WHHipL45fyc3B/1A6cdDieYe0V7OdbKT+1Bbl56OtzOG fDQ5dwG1G/4CIBImjNpMhqosHuC6h7tsgt5a28lXKXZXvNyTFNdKbAL2BY9W5kd6X5Ph FdBA== Received: by 10.68.132.232 with SMTP id ox8mr3399728pbb.145.1332268271371; Tue, 20 Mar 2012 11:31:11 -0700 (PDT) Received: from dormouse.experts-exchange.com ([72.29.164.238]) by mx.google.com with ESMTPS id l8sm1796474pbd.62.2012.03.20.11.31.09 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 20 Mar 2012 11:31:10 -0700 (PDT) Sender: Jason Helfman Date: Tue, 20 Mar 2012 11:30:18 -0700 From: Jason Helfman To: Jung-uk Kim Message-ID: <20120320183018.GA13507@dormouse.experts-exchange.com> References: <20120318180225.GA51618@dormouse.experts-exchange.com> <20120319230818.GJ46825@dormouse.experts-exchange.com> <20120320015836.GA83617@misty.eyesbeyond.com> <201203201241.04720.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <201203201241.04720.jkim@FreeBSD.org> X-Operating-System: FreeBSD 8.2-RELEASE amd64 Organization: The FreeBSD Project, http://www.freebsd.org X-Living-The-Dream: I love the SLO Life! X-PGP-FingerPrint: 8E0D C457 9A0F C91C 23F3 0454 2059 9A63 4150 D3DC X-PGP-Key: http://people.freebsd.org/~jgh/jgh.asc User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQlYzYfhbPvxEp5I4aWpC+wZosv+fgl1Mz1mJMYZGmi6xzhdfgXGmb61LXmtwQOnYnel39Ko Cc: freebsd-eclipse@FreeBSD.org, freebsd-java@FreeBSD.org Subject: Re: [RFC] New Port: Eclipse Java Compiler, java/eclipse-ecj X-BeenThere: freebsd-eclipse@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "FreeBSD users of eclipse EDI, tools, rich client apps & ports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2012 18:31:12 -0000 On Tue, Mar 20, 2012 at 12:41:02PM -0400, Jung-uk Kim thus spake: >On Monday 19 March 2012 09:58 pm, Greg Lewis wrote: >> On Mon, Mar 19, 2012 at 04:08:18PM -0700, Jason Helfman wrote: >> > On Mon, Mar 19, 2012 at 07:00:39PM -0400, Jung-uk Kim thus spake: >> > >Hmm... It doesn't seem right. >> > > >> > >% cat /usr/local/bin/ecj.sh >> > >#!/bin/sh >> > > >> > >/usr/local/openjdk6/bin/javac -classpath >> > > /usr/local/share/java/classes/ecj.jar $1 % >> > > /usr/local/bin/ecj.sh -version >> > >javac 1.6.0_30 >> > >% /usr/local/openjdk6/bin/javac -version >> > >javac 1.6.0_30 >> > > >> > >Please note it isn't coming from ecj.jar. >> > >> > That is grabbing the version of javac based on the shell script. >> > I'm not certain if you can get a vesion of the jar with an >> > argument, or if that argument is even valid. >> > >> > >Also, `$1' should be `$*'. >> >> I could be wrong, but I thought the preferred version of this was >> "$@" (as is, including the double quotes). IIRC using $* doesn't >> quite work properly if some of your arguments have spaces in them. > >Ah, you're right, "$@" is better than $* in this case. I can change this. > >> Instead of %%JAVAC%% I'd suggest %%LOCALBASE%%/bin/javac so that >> the selection of which JDK to use can be done at run time rather >> than port install time. > >I totally agree with you, too. However, it should be java. javac >cannot "execute" ecj.jar. I was able to compile with javac, but not with java. Do you have the arguments you've used to compile with ecj.jar with using "java" > >Thanks, > >Jung-uk Kim > Thanks, Jason -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh