From owner-cvs-src@FreeBSD.ORG Thu May 6 19:37:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EEECC16A4CE for ; Thu, 6 May 2004 19:37:04 -0700 (PDT) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 2E19543D1D for ; Thu, 6 May 2004 19:37:03 -0700 (PDT) (envelope-from nate@root.org) Received: (qmail 44979 invoked by uid 1000); 7 May 2004 02:37:05 -0000 Date: Thu, 6 May 2004 19:37:05 -0700 (PDT) From: Nate Lawson To: "M. Warner Losh" In-Reply-To: <20040506.203312.01491062.imp@bsdimp.com> Message-ID: <20040506193513.O44970@root.org> References: <200405061554.i46Fs3q4023478@repoman.freebsd.org> <200405061241.42766.jhb@FreeBSD.org> <20040506105124.O42462@root.org> <20040506.203312.01491062.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 legacy.c src/sys/kern subr_smp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2004 02:37:05 -0000 On Thu, 6 May 2004, M. Warner Losh wrote: > In message: <20040506105124.O42462@root.org> > Nate Lawson writes: > : On Thu, 6 May 2004, John Baldwin wrote: > : > On Thursday 06 May 2004 11:54 am, Nate Lawson wrote: > : > > njl 2004/05/06 08:54:03 PDT > : > > > : > > FreeBSD src repository > : > > > : > > Modified files: > : > > sys/i386/i386 legacy.c > : > > sys/kern subr_smp.c > : > > Log: > : > > Move the CPU newbus attachment to i386 legacy. The acpi_cpu device will > : > > become just "cpu" and provide attachments in the !legacy case. > : > > > : > > Tested by: des > : > > : > By the way, it would be nice if the acpi_cpu(4) driver would still probe and > : > attach to devices for non-existent CPUs but just device_disable() the > : > associated device_t. This would keep the device from reprobing all the time. > : > : Good idea, I'll make that change tonight. The code I committed this > : morning returns ENXIO for them so probe will get called multiple times. > : Hmm, this may be more difficult than I first thought since some of the > : internal routines walk all devices in the devclass, operating on their > : resources. This change would require that code to have an extra case, > : "device here but not active". Right now it assumes that if the device is > : probed/attached, it is usable. > > The device is already there. All the device_disable() would do would > keep it from being probed again. Yep, I realized that later. There's nothing requiring a driver to attach a device to call device_disable() on it. I'm still not comfortable making that change yet. It doesn't hurt anything to rescan the cpu probe methods. And perhaps a change like enabling HTT will eventually trigger a rescan and acpi_cpu can attach to the now available processor. -Nate