From owner-freebsd-bugs@FreeBSD.ORG Thu Jan 20 15:00:41 2005 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6C95F16A4CE for ; Thu, 20 Jan 2005 15:00:41 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 21B1443D39 for ; Thu, 20 Jan 2005 15:00:41 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j0KF0fVp024569 for ; Thu, 20 Jan 2005 15:00:41 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j0KF0emM024567; Thu, 20 Jan 2005 15:00:40 GMT (envelope-from gnats) Resent-Date: Thu, 20 Jan 2005 15:00:40 GMT Resent-Message-Id: <200501201500.j0KF0emM024567@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitrij Tejblum Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2136F16A4CE for ; Thu, 20 Jan 2005 14:50:36 +0000 (GMT) Received: from developer.yandex.ru (developer.yandex.ru [213.180.193.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3152743D1F for ; Thu, 20 Jan 2005 14:50:35 +0000 (GMT) (envelope-from tejblum@developer.yandex.ru) Received: from developer.yandex.ru (localhost [127.0.0.1]) by developer.yandex.ru (8.13.1/8.13.1) with ESMTP id j0KEoXmD050098 for ; Thu, 20 Jan 2005 17:50:33 +0300 (MSK) (envelope-from tejblum@developer.yandex.ru) Received: (from tejblum@localhost) by developer.yandex.ru (8.13.1/8.13.1/Submit) id j0KEoX6I050097; Thu, 20 Jan 2005 17:50:33 +0300 (MSK) (envelope-from tejblum) Message-Id: <200501201450.j0KEoX6I050097@developer.yandex.ru> Date: Thu, 20 Jan 2005 17:50:33 +0300 (MSK) From: Dmitrij Tejblum To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/76504: Keep-alives doesn't work on half-closed sockets. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dmitrij Tejblum List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jan 2005 15:00:41 -0000 >Number: 76504 >Category: kern >Synopsis: Keep-alives doesn't work on half-closed sockets. >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jan 20 15:00:40 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Dmitrij Tejblum >Release: FreeBSD 5.3-STABLE i386 >Organization: >Environment: >Description: When a TCP socket is shutdown for writing, but isn't closed and isn't shutdown for reading, then keep-alives does not work on this socket. >How-To-Repeat: Set sysctl net.inet.tcp.keepintvl to several seconds, create a half-closed connection, and look with tcpdump. Half-closed connection may be create by e.g. rsh -n. >Fix: --- tcp_timer.c Mon Jan 17 15:06:36 2005 +++ tcp_timer.c Thu Jan 20 16:24:11 2005 @@ -336,7 +336,7 @@ if (tp->t_state < TCPS_ESTABLISHED) goto dropit; if ((always_keepalive || inp->inp_socket->so_options & SO_KEEPALIVE) && - tp->t_state <= TCPS_CLOSING) { + (tp->t_state <= TCPS_CLOSING || tp->t_state == TCPS_FIN_WAIT_2)) { if ((ticks - tp->t_rcvtime) >= tcp_keepidle + tcp_maxidle) goto dropit; /* >Release-Note: >Audit-Trail: >Unformatted: