From owner-freebsd-current@FreeBSD.ORG Mon Jun 15 20:14:09 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4CBAC106566C; Mon, 15 Jun 2009 20:14:09 +0000 (UTC) (envelope-from stefan@fafoe.narf.at) Received: from viefep15-int.chello.at (viefep15-int.chello.at [62.179.121.35]) by mx1.freebsd.org (Postfix) with ESMTP id 2A9778FC1B; Mon, 15 Jun 2009 20:14:07 +0000 (UTC) (envelope-from stefan@fafoe.narf.at) Received: from edge02.upc.biz ([192.168.13.237]) by viefep19-int.chello.at (InterMail vM.7.09.01.00 201-2219-108-20080618) with ESMTP id <20090615195426.SSKJ8900.viefep19-int.chello.at@edge02.upc.biz>; Mon, 15 Jun 2009 21:54:26 +0200 Received: from lizard.fafoe.narf.at ([213.47.85.26]) by edge02.upc.biz with edge id 4KuQ1c01r0a5KZh02KuRzN; Mon, 15 Jun 2009 21:54:26 +0200 X-SourceIP: 213.47.85.26 Received: by lizard.fafoe.narf.at (Postfix, from userid 1001) id 02ACDBABD; Mon, 15 Jun 2009 21:54:23 +0200 (CEST) Date: Mon, 15 Jun 2009 21:54:23 +0200 From: Stefan Farfeleder To: Sam Leffler Message-ID: <20090615195422.GB1418@lizard.fafoe.narf.at> Mail-Followup-To: Sam Leffler , Roman Divacky , current@freebsd.org References: <20090615181555.GA52009@freebsd.org> <4A369529.5090004@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A369529.5090004@freebsd.org> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Roman Divacky , current@freebsd.org Subject: Re: [RFC]: (void)0 instead of empty defines X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2009 20:14:09 -0000 On Mon, Jun 15, 2009 at 11:38:33AM -0700, Sam Leffler wrote: > > Are you saying that: > > if (cond) > ; > > is considered worthy of a warning by the compiler? Is it just "if" or all > conditional control constructs (e.g. while)? > > I can image many instances of this construct arising from debugging > facilities. This sounds like a stupid restriction and I would argue we > should just disable the warning. GCC warns too with -Wextra.