From owner-svn-src-all@FreeBSD.ORG Mon Nov 15 14:40:55 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 74A1E106564A; Mon, 15 Nov 2010 14:40:55 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4508D8FC13; Mon, 15 Nov 2010 14:40:53 +0000 (UTC) Received: by fxm19 with SMTP id 19so3969547fxm.13 for ; Mon, 15 Nov 2010 06:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject :organization:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=PjsbLfKHmCq3dO8Of/Q+CDEsRve7OOY3EPwCMr5Popo=; b=Z14XVrZ0EXo4fP7e3e1fB32iK/jzU6T9s4uC2eg8lg5frndgmN+XsNVJWHgv+MadP5 g3VPwP/S9K1hLhtTbro8X5OLlSjUlMvGApQy1VcXZtZEQVMaAk7oJw6UfYk++qTaFGt0 xOJ+TI2TXLvPnOjmJDi+d5DKzK7Vl3vGHNomY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=FdxBEEaCqLwzru6rmoqsebJoPUazCBAe4sWwoQFffOVzBHi1aQyy3AItEeYCR6PchX b56+oxPDVJ1/zGfWzAytvOZ6IbUia0M733Rg0gtvZiiigv/OYYQOMB6mz9rWyzfNWvfW mCeikJxgrYZjb94r9CKkROSfFRbRe0uKezpkw= Received: by 10.223.97.73 with SMTP id k9mr875763fan.120.1289832053164; Mon, 15 Nov 2010 06:40:53 -0800 (PST) Received: from localhost (ua1.etadirect.net [91.198.140.16]) by mx.google.com with ESMTPS id 16sm873620fal.0.2010.11.15.06.40.51 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 15 Nov 2010 06:40:51 -0800 (PST) From: Mikolaj Golub To: Lawrence Stewart Organization: TOA Ukraine References: <201011120641.oAC6fui3098584@svn.freebsd.org> <8662w17e90.fsf@kopusha.home.net> <4CDF3A58.6080505@freebsd.org> <86pqu8q6lb.fsf@kopusha.home.net> <4CE08BB6.1090304@freebsd.org> <86ipzyncqf.fsf@zhuzha.ua1> <4CE139C5.4010300@freebsd.org> Date: Mon, 15 Nov 2010 16:40:49 +0200 In-Reply-To: <4CE139C5.4010300@freebsd.org> (Lawrence Stewart's message of "Tue, 16 Nov 2010 00:46:45 +1100") Message-ID: <86aalamyz2.fsf@zhuzha.ua1> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215166 - in head: . sys/conf sys/netinet sys/netinet/cc sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2010 14:40:55 -0000 On Tue, 16 Nov 2010 00:46:45 +1100 Lawrence Stewart wrote: LS> Ok thanks. If you are or anyone else is feeling really adventurous, I LS> have created a series of patches that add better VIMAGE support to the LS> framework. LS> If you feel like testing them, they need to be applied in the following LS> order: LS> 1. Init the CC framework global state only once on system boot by LS> switching to a SYSINIT. (You already have this one) LS> http://people.freebsd.org/~lstewart/patches/5cc/modcc_vnetpanic_ccinit_v2.patch LS> 2. When unloading an algo module, loop through all TCP control blocks in LS> all vnets (instead of just the default vnet) to look for connections LS> using the algo. LS> http://people.freebsd.org/~lstewart/patches/5cc/modcc_vnet_algounloadcleanup.patch LS> 3. Move protocol specific implementation detail out of the core CC LS> framework (not vnet specific but useful cleanup). LS> http://people.freebsd.org/~lstewart/patches/5cc/modcc_tcpalgounload.patch LS> 4. Create a per-vnet variable to store a ptr to the vnet's default CC LS> algo and hook it up to a vnet aware sysctl handler. vnets can now choose LS> their own default from the global list of registered algos independently LS> of other vnets. LS> http://people.freebsd.org/~lstewart/patches/5cc/modcc_pervnet_defaultalgo.patch LS> It would be fine to test all of them in one go. The last one is the most LS> intrusive and the one I'd most like to see some testing done with. Only LS> if you feel like it of course. Feeling virtually adventurous, applied them all on VirtualBox :-). This is the box where the hang is not observed. It works ok for me so far. I will try at home too (where the hang is observed) and let you know if there are any issues. -- Mikolaj Golub