From owner-freebsd-arch@FreeBSD.ORG Fri May 9 14:50:48 2003 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 48FA237B401 for ; Fri, 9 May 2003 14:50:48 -0700 (PDT) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id A896C43FAF for ; Fri, 9 May 2003 14:50:47 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 8085 invoked from network); 9 May 2003 21:50:54 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 9 May 2003 21:50:54 -0000 Received: from laptop.baldwin.cx ([216.133.140.1]) by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h49Loep0013414 for ; Fri, 9 May 2003 17:50:40 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Date: Fri, 09 May 2003 17:50:46 -0400 (EDT) From: John Baldwin To: arch@FreeBSD.org Subject: [Bikeshed] sigacts locking X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2003 21:50:48 -0000 As part of the locking for the proc structure, I needed to lock the procsig and sigacts stuctures so that kill(), killpg(), sigaction() and a few other system calls can be pulled out from under Giant. After talking with Peter some, I decided to pull the sigacts structure out of the u-area and merge it with the procsig structure under the sigacts name. I then added a mutex to each sigacts and added locking where appropriate. With this change, the aforementioned system calls are now MP safe along with sendsig(), *signal(), cursig(), etc. The patch for all this is at http://www.FreeBSD.org/~jhb/patches/sigacts.patch I would appreciate comments, review, etc. that people may have. If all goes well I hope to get this into 5.1. Thanks. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/