From owner-svn-src-all@freebsd.org Tue Sep 3 14:07:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 68693DCB9C; Tue, 3 Sep 2019 14:06:34 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7zY31lFz4PgZ; Tue, 3 Sep 2019 14:06:33 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id AA3B21A840; Tue, 3 Sep 2019 14:06:11 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 52F3B1FF7B; Tue, 9 Apr 2019 18:38:12 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 240D67261D; Tue, 9 Apr 2019 18:38:12 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 161CD1FF7A; Tue, 9 Apr 2019 18:38:12 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 92D7C1FF76; Tue, 9 Apr 2019 18:38:08 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F0E727261A; Tue, 9 Apr 2019 18:38:07 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x39IX4JY061477; Tue, 9 Apr 2019 11:33:04 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x39IX4pW061476; Tue, 9 Apr 2019 11:33:04 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201904091833.x39IX4pW061476@gndrsh.dnsmgr.net> Subject: Re: svn commit: r346017 - in head: libexec/rc libexec/rc/rc.d share/man/man5 In-Reply-To: <749EBFB4-94B8-4FD9-8774-FE6FB18FFA07@bayofrum.net> To: Chris Rees CC: "O. Hartmann" , Chris Rees , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 240D67261D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Status: O X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:07:13 -0000 X-Original-Date: Tue, 9 Apr 2019 11:33:04 -0700 (PDT) X-List-Received-Date: Tue, 03 Sep 2019 14:07:13 -0000 > Hey, > > On 9 April 2019 14:13:54 BST, "O. Hartmann" wrote: > >On Sun, 7 Apr 2019 18:31:45 +0000 (UTC) > >Chris Rees wrote: > > > >> Author: crees (doc,ports committer) > >> Date: Sun Apr 7 18:31:45 2019 > >> New Revision: 346017 > >> URL: https://svnweb.freebsd.org/changeset/base/346017 > >> > >> Log: > >> Remove now unnecessary kldstat check before attempting to load > >modules. > >> > >> Since r233109, kldload has the -n option, which silently ignores > >options > >> that are already loaded. > >> > >> > >https://lists.freebsd.org/pipermail/freebsd-rc/2018-December/003899.html > >> > >> Note that this script no longer reports if the module is already > >loaded, > >> but it could be argued this wasn't particularly useful information. > >> > >> PR: docs/234248 > >> Reviewed by: bcr (docs), kib, rgrimes (visual) > >> Approved by: jilles > >> Differential Revision: https://reviews.freebsd.org/D18670 > >> > >> Modified: > >> head/libexec/rc/rc.d/abi > >> head/libexec/rc/rc.d/bthidd > >> head/libexec/rc/rc.d/cfumass > >> head/libexec/rc/rc.d/kld > >> head/libexec/rc/rc.d/mdconfig > >> head/libexec/rc/rc.d/mdconfig2 > >> head/libexec/rc/rc.d/mountcritremote > >> head/libexec/rc/rc.d/syscons > >> head/libexec/rc/rc.subr > >> head/share/man/man5/rc.conf.5 > >> > >> Modified: head/libexec/rc/rc.d/abi > >> > >============================================================================== > > > {Snip} > > > >It seems this patch breaks ZFS if ZFS is built-in kernel! > > > >Having ZFS as kernel built-in leaves the system not mounting ANY(!) ZFS > >volume > >at boot time, rendering servers unusable. > >Mounting ZFS filesystems with "zfs mount -a" bring back the ZFS > >filesystems as > >expected. > > > > Are you sure it's this causing that? Please try reverting it. I think the trigger issue is: grep zfs /etc/rc.d/zvol rcvar="zfs_enable" required_modules="zfs" that module requires may be going south with the new code when the module is built into the kernel. > Chris -- Rod Grimes rgrimes@freebsd.org