From owner-svn-src-user@FreeBSD.ORG  Sat Jun 15 10:09:21 2013
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 224DC4C4;
 Sat, 15 Jun 2013 10:09:21 +0000 (UTC)
 (envelope-from attilio@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 141FB1046;
 Sat, 15 Jun 2013 10:09:21 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r5FA9K75022016;
 Sat, 15 Jun 2013 10:09:20 GMT (envelope-from attilio@svn.freebsd.org)
Received: (from attilio@localhost)
 by svn.freebsd.org (8.14.7/8.14.5/Submit) id r5FA9K2T022015;
 Sat, 15 Jun 2013 10:09:20 GMT (envelope-from attilio@svn.freebsd.org)
Message-Id: <201306151009.r5FA9K2T022015@svn.freebsd.org>
From: Attilio Rao <attilio@FreeBSD.org>
Date: Sat, 15 Jun 2013 10:09:20 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-user@freebsd.org
Subject: svn commit: r251788 - user/attilio/vmobj-readlock/sys/kern
X-SVN-Group: user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Jun 2013 10:09:21 -0000

Author: attilio
Date: Sat Jun 15 10:09:20 2013
New Revision: 251788
URL: http://svnweb.freebsd.org/changeset/base/251788

Log:
  Avoid to soft busy the page before to do vn_rdwr() in kern_sendfile().
  That is unnecessary.  The page is infact already wired and concurrent
  accesses to the specified page and off should be serialized
  already by vn_rdwr().
  
  Sponsored by:	EMC / Isilon storage division
  Discussed with:	jeff, dillon

Modified:
  user/attilio/vmobj-readlock/sys/kern/uipc_syscalls.c

Modified: user/attilio/vmobj-readlock/sys/kern/uipc_syscalls.c
==============================================================================
--- user/attilio/vmobj-readlock/sys/kern/uipc_syscalls.c	Sat Jun 15 10:08:34 2013	(r251787)
+++ user/attilio/vmobj-readlock/sys/kern/uipc_syscalls.c	Sat Jun 15 10:09:20 2013	(r251788)
@@ -2219,11 +2219,6 @@ retry_space:
 			else {
 				ssize_t resid;
 
-				/*
-				 * Ensure that our page is still around
-				 * when the I/O completes.
-				 */
-				vm_page_io_start(pg);
 				VM_OBJECT_WUNLOCK(obj);
 
 				/*
@@ -2237,11 +2232,9 @@ retry_space:
 				    trunc_page(off), UIO_NOCOPY, IO_NODELOCKED |
 				    IO_VMIO | ((MAXBSIZE / bsize) << IO_SEQSHIFT),
 				    td->td_ucred, NOCRED, &resid, td);
-				VM_OBJECT_WLOCK(obj);
-				vm_page_io_finish(pg);
-				if (!error)
-					VM_OBJECT_WUNLOCK(obj);
 				mbstat.sf_iocnt++;
+				if (error)
+					VM_OBJECT_WLOCK(obj);
 			}
 			if (error) {
 				vm_page_lock(pg);