From owner-freebsd-scsi Mon Sep 23 13:37:43 2002 Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F359637B401; Mon, 23 Sep 2002 13:37:41 -0700 (PDT) Received: from beppo.feral.com (beppo.feral.com [192.67.166.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 68A7443E75; Mon, 23 Sep 2002 13:37:41 -0700 (PDT) (envelope-from mjacob@feral.com) Received: from mailhost.feral.com (mjacob@mailhost.feral.com [192.67.166.1]) by beppo.feral.com (8.11.3/8.11.3) with ESMTP id g8NKbd101113; Mon, 23 Sep 2002 13:37:39 -0700 (PDT) (envelope-from mjacob@feral.com) Date: Mon, 23 Sep 2002 13:37:39 -0700 (PDT) From: Matthew Jacob X-Sender: mjacob@beppo Reply-To: mjacob@feral.com To: Brooks Davis Cc: Matt Jacob , scsi@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.c In-Reply-To: <20020923132415.A24262@Odin.AC.HMC.Edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Mon, 23 Sep 2002, Brooks Davis wrote: > On Sun, Sep 22, 2002 at 09:56:35PM -0700, Matt Jacob wrote: > > mjacob 2002/09/22 21:56:35 PDT > > > > Modified files: > > sys/cam/scsi scsi_all.c > > Log: > > A SCSI_DELAY of zero is a legitimate value to have. > > The notion that you must "always" have a delay is at best misinformed. > > This change only half fixed the check since there a boot/runtime check > at the bottom of the file in sec_scsi_delay. Oh, well, yes, I didn't catch/change this. I don't really care about what the sysctl does/claims to do- it's not really pertinent for what I was trying to get to. I just wanted to fix the compile time wrong. > > If we're going to allow 0 we should probably also allow values between > 0 and 100 as well and just toss the checks. I don't really object to > letting the user take aim at their foot if that's what they want to do. You don't understand the real issue, which is that delaying after a bus reset is an SPI-only issue, and one that is not encapsulated in any spec in any hard and fast way- so don't talk bout 'aiming at foot' unless it the thing you're aiming happens to be your nourishment mandibiles. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message