From owner-svn-src-all@freebsd.org Mon May 21 01:11:44 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A4527EAA02E; Mon, 21 May 2018 01:11:44 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (unknown [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C45D80BC8; Mon, 21 May 2018 01:11:44 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 3804C116EB; Mon, 21 May 2018 01:11:44 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-it0-f47.google.com with SMTP id q4-v6so19350245ite.3; Sun, 20 May 2018 18:11:44 -0700 (PDT) X-Gm-Message-State: ALKqPwdEswbbf11MRqJImTXTgicnOAtQj/Fq25OvvuyZHXl/H2sgEwqN DwQAyDh4xJ6Gle0KX5eNQyfbbenP+6LQ6xOu/Ik= X-Google-Smtp-Source: AB8JxZolRdLUnztGY/0XL0vGZDT9Aw1XSqQPDZVo6FAiydXxV7h1UVWSKtb5ISIjOOn/lheaH2CJgteI1ITosQi0lhg= X-Received: by 2002:a24:5b54:: with SMTP id g81-v6mr15405653itb.7.1526865103714; Sun, 20 May 2018 18:11:43 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:85ae:0:0:0:0:0 with HTTP; Sun, 20 May 2018 18:11:43 -0700 (PDT) In-Reply-To: References: <201805200614.w4K6EC0L023252@repo.freebsd.org> From: Matthew Macy Date: Sun, 20 May 2018 18:11:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r333924 - head/sys/fs/nfsclient To: Rick Macklem Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 01:11:44 -0000 I don't understand why you can't install the gcc8 package but here you go: https://people.freebsd.org/~mmacy/gcc8logs/nfs-GENERIC-NODEBUG.log https://people.freebsd.org/~mmacy/gcc8logs/nfs-GENERIC.log On Sun, May 20, 2018 at 5:17 PM, Rick Macklem wrote: > I'm not in a situation where I can use gcc, but if you email me the > list of warnings, I can look at them. > > rick > > ________________________________________ > From: Matthew Macy > Sent: Sunday, May 20, 2018 7:16:31 PM > To: Rick Macklem > Cc: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-head@freebsd.org > Subject: Re: svn commit: r333924 - head/sys/fs/nfsclient > > Actually if you could clean up the NFS code that would be great. It's > _full_ of set but not used warnings. And anyone else reading this if > you could clean up other areas. I've mostly cleaned up kern / net / > netinet / iflib drivers. > > > both > WITHOUT_FORMAT_EXTENSIONS= XCC=/usr/local/bin/gcc8 make -j buildkernel > > and > WITHOUT_FORMAT_EXTENSIONS= XCC=/usr/local/bin/gcc8 make -j > buildkernel KERNCONF=GENERIC-NODEBUG > > Thanks. > > On Sun, May 20, 2018 at 4:09 PM, Matthew Macy wrote: >> gcc8 >> >> On Sun, May 20, 2018 at 15:14 Rick Macklem wrote: >>> >>> Matt Macy wrote: >>> >Author: mmacy >>> >Date: Sun May 20 06:14:12 2018 >>> >New Revision: 333924 >>> >URL: https://svnweb.freebsd.org/changeset/base/333924 >>> > >>> >Log: >>> > nfsclient: warnings cleanups >>> Just wondering what compiler you are using. I haven't seen warnings for >>> these? >>> FYI, for the first two cases, ncookie is always set before it is used. >>> For the third, "rflags" is set but not used. I sometimes leave code like >>> this in >>> the tree since I might need those argument flags later and might not >>> remember >>> how to get them. In this case, similar code in other functions set >>> "rflags" in the >>> same way, so it shouldn't be hard to crib the assignment from there. >>> As such, I don't have a problem with deleting the code. >>> >>> rick >>> ... the commit patch ... >>> Modified: >>> head/sys/fs/nfsclient/nfs_clcomsubs.c >>> head/sys/fs/nfsclient/nfs_clrpcops.c >>> >>> Modified: head/sys/fs/nfsclient/nfs_clcomsubs.c >>> >>> ============================================================================== >>> --- head/sys/fs/nfsclient/nfs_clcomsubs.c Sun May 20 05:59:42 2018 >>> (r333923) >>> +++ head/sys/fs/nfsclient/nfs_clcomsubs.c Sun May 20 06:14:12 2018 >>> (r333924) >>> @@ -354,7 +354,7 @@ nfsm_uiombuflist(struct uio *uiop, int siz, struct mbu >>> char *uiocp; >>> struct mbuf *mp, *mp2, *firstmp; >>> int xfer, left, mlen; >>> - int uiosiz, clflg, rem; >>> + int uiosiz, clflg; >>> char *tcp; >>> >>> KASSERT(uiop->uio_iovcnt == 1, ("nfsm_uiotombuf: iovcnt != 1")); >>> @@ -363,7 +363,6 @@ nfsm_uiombuflist(struct uio *uiop, int siz, struct mbu >>> clflg = 1; >>> else >>> clflg = 0; >>> - rem = NFSM_RNDUP(siz) - siz; >>> if (clflg != 0) >>> NFSMCLGET(mp, M_WAITOK); >>> else >>> >>> Modified: head/sys/fs/nfsclient/nfs_clrpcops.c >>> >>> ============================================================================== >>> --- head/sys/fs/nfsclient/nfs_clrpcops.c Sun May 20 05:59:42 2018 >>> (r333923) >>> +++ head/sys/fs/nfsclient/nfs_clrpcops.c Sun May 20 06:14:12 2018 >>> (r333924) >>> @@ -2845,7 +2845,7 @@ nfsrpc_readdir(vnode_t vp, struct uio *uiop, >>> nfsuint64 >>> KASSERT(uiop->uio_iovcnt == 1 && >>> (uio_uio_resid(uiop) & (DIRBLKSIZ - 1)) == 0, >>> ("nfs readdirrpc bad uio")); >>> - >>> + ncookie.lval[0] = ncookie.lval[1] = 0; >>> /* >>> * There is no point in reading a lot more than uio_resid, however >>> * adding one additional DIRBLKSIZ makes sense. Since uio_resid >>> @@ -3288,6 +3288,7 @@ nfsrpc_readdirplus(vnode_t vp, struct uio *uiop, >>> nfsui >>> KASSERT(uiop->uio_iovcnt == 1 && >>> (uio_uio_resid(uiop) & (DIRBLKSIZ - 1)) == 0, >>> ("nfs readdirplusrpc bad uio")); >>> + ncookie.lval[0] = ncookie.lval[1] = 0; >>> timespecclear(&dctime); >>> *attrflagp = 0; >>> if (eofp != NULL) >>> @@ -6943,6 +6944,7 @@ nfsrv_parseug(struct nfsrv_descript *nd, int dogrp, >>> ui >>> >>> NFSM_DISSECT(tl, uint32_t *, NFSX_UNSIGNED); >>> len = fxdr_unsigned(uint32_t, *tl); >>> + str = NULL; >>> if (len > NFSV4_OPAQUELIMIT) { >>> error = NFSERR_BADXDR; >>> goto nfsmout; >>> @@ -7244,7 +7246,6 @@ nfsrpc_createlayout(vnode_t dvp, char *name, int >>> namel >>> struct nfsclsession *tsep; >>> nfsattrbit_t attrbits; >>> nfsv4stateid_t stateid; >>> - uint32_t rflags; >>> struct nfsmount *nmp; >>> >>> nmp = VFSTONFS(dvp->v_mount); >>> @@ -7327,7 +7328,6 @@ nfsrpc_createlayout(vnode_t dvp, char *name, int >>> namel >>> stateid.other[0] = *tl++; >>> stateid.other[1] = *tl++; >>> stateid.other[2] = *tl; >>> - rflags = fxdr_unsigned(u_int32_t, *(tl + 6)); >>> nfsrv_getattrbits(nd, &attrbits, NULL, NULL); >>> NFSM_DISSECT(tl, u_int32_t *, NFSX_UNSIGNED); >>> deleg = fxdr_unsigned(int, *tl); >>> >>