From owner-svn-src-head@FreeBSD.ORG Sat Jun 5 08:16:21 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AAF88106566C; Sat, 5 Jun 2010 08:16:21 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from svn.freebsd.org (unknown [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 9B18D8FC16; Sat, 5 Jun 2010 08:16:21 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o558GLjd061690; Sat, 5 Jun 2010 08:16:21 GMT (envelope-from mav@svn.freebsd.org) Received: (from mav@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o558GLhb061688; Sat, 5 Jun 2010 08:16:21 GMT (envelope-from mav@svn.freebsd.org) Message-Id: <201006050816.o558GLhb061688@svn.freebsd.org> From: Alexander Motin Date: Sat, 5 Jun 2010 08:16:21 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r208817 - head/sys/dev/siis X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jun 2010 08:16:21 -0000 Author: mav Date: Sat Jun 5 08:16:21 2010 New Revision: 208817 URL: http://svn.freebsd.org/changeset/base/208817 Log: Plug memory leak to silent Coverity. Error is still not really handled. Found with: Coverity Prevent(tm) CID: 4196 Modified: head/sys/dev/siis/siis.c Modified: head/sys/dev/siis/siis.c ============================================================================== --- head/sys/dev/siis/siis.c Sat Jun 5 08:14:19 2010 (r208816) +++ head/sys/dev/siis/siis.c Sat Jun 5 08:16:21 2010 (r208817) @@ -1338,6 +1338,7 @@ siis_issue_read_log(device_t dev) ataio = &ccb->ataio; ataio->data_ptr = malloc(512, M_SIIS, M_NOWAIT); if (ataio->data_ptr == NULL) { + xpt_free_ccb(ccb); device_printf(dev, "Unable allocate memory for READ LOG command"); return; /* XXX */ }