From owner-freebsd-bugs@freebsd.org Sat Nov 28 05:26:48 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4EA0C47668C for ; Sat, 28 Nov 2020 05:26:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4Cjg3D1Rbqz3D3F for ; Sat, 28 Nov 2020 05:26:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 2FBB44763CB; Sat, 28 Nov 2020 05:26:48 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2F80147668B for ; Sat, 28 Nov 2020 05:26:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cjg3D0hykz3CmN for ; Sat, 28 Nov 2020 05:26:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 06E4821C63 for ; Sat, 28 Nov 2020 05:26:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0AS5Qlmh039722 for ; Sat, 28 Nov 2020 05:26:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0AS5Ql4U039721 for bugs@FreeBSD.org; Sat, 28 Nov 2020 05:26:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 251433] unionfs copymode transparent creates files with current euid instead of lower layer file owner uid. Date: Sat, 28 Nov 2020 05:26:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: raj@gusw.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Nov 2020 05:26:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251433 Bug ID: 251433 Summary: unionfs copymode transparent creates files with current euid instead of lower layer file owner uid. Product: Base System Version: 12.2-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: raj@gusw.net Test: -1. as root ------------------------------------------------------- cd /tmp mkdir test-upper mkdir test-union echo "I'm root!" > test-union/data chmod 755 test-* chown -R root:wheel test-* chmod 664 test-* mount -t unionfs -o copymode=3Dtranspaent test-upper test-union -2. as another user in group wheel --------------------------------- cd /tmp cat test-union/data # I'm root! ls -l test-union/data # -rw-rw-r-- root wheel 10 test-union/data echo "But I'm not root!" > test-union/data cat test-union/data # But I'm not root! ls -l test-union/data # -rw-rw-r-- user wheel 18 test-union/data rm test-upper/data cat test-union/data # I'm root! ls -l test-union/data # -rw-rw-r-- root wheel 10 test-union/data ---------------------------------------------------------------------- You see, if the copymode=3Dtransparent was working right, it would create t= hat copy of test-union/data on the upper layer using the owner uid "root" not "user". But somehow it is not doing that.=20 And just to be clear, a simple overwrite of an existing file by an euid different from the owener uid does not change the owner uid.=20 So this is a bug, but it's complicated, because the code says very clearly= =20 Out of unionfs_subr.c unionfs_copyfile(...) calls unionfs_vn_create_on_upper(...) calls unionfs_create_uppervattr_core(...) does case UNIONFS_TRANSPARENT: uva->va_mode =3D lva->va_mode; uva->va_uid =3D lva->va_uid; uva->va_gid =3D lva->va_gid; break; which uva is then used in the VOP_CREATE call. What could the problem be here? Something is apparently "correcting" the uva->va_unid setting between here and the final effect of VOP_CREATE. --=20 You are receiving this mail because: You are the assignee for the bug.=