From owner-cvs-src@FreeBSD.ORG Wed Sep 28 23:39:51 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2B32616A420 for ; Wed, 28 Sep 2005 23:39:51 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mail2.fluidhosting.com [204.14.90.62]) by mx1.FreeBSD.org (Postfix) with SMTP id 4022B43D5A for ; Wed, 28 Sep 2005 23:39:48 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 13255 invoked by uid 399); 28 Sep 2005 23:39:47 -0000 Received: from mail1.fluidhosting.com (204.14.90.61) by mail2.fluidhosting.com with SMTP; 28 Sep 2005 23:39:47 -0000 Received: (qmail 65575 invoked by uid 399); 28 Sep 2005 23:39:47 -0000 Received: from localhost (HELO ?192.168.0.5?) (dougb@dougbarton.net@127.0.0.1) by localhost with SMTP; 28 Sep 2005 23:39:47 -0000 Message-ID: <433B29C2.10504@FreeBSD.org> Date: Wed, 28 Sep 2005 16:39:46 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200509270751.j8R7pjbj068445@repoman.freebsd.org> <433A04D4.9040602@portaone.com> <200509281304.29338.jhb@FreeBSD.org> In-Reply-To: <200509281304.29338.jhb@FreeBSD.org> X-Enigmail-Version: 0.92.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, Maxim.Sobolev@portaone.com, Kirill Ponomarew , src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib match.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2005 23:39:51 -0000 John Baldwin wrote: > On Tuesday 27 September 2005 10:49 pm, Maxim Sobolev wrote: > >>IMHO this is an ugly hack. Handling some packages differently purely >>based on their name is simply a completely wrong way to go. The proper >>way to implement this is to add additional PLIST flag which will tell >>pkg_* tools to ignore absent origin. > > > Umm, there's a bit of a chicken and egg in that if you could edit the package > in question to put a custom @noorigin in the packing list you could already > just put a bogus @origin in the packing list. I think the warning should just > be shut up across the board anyways as not all pkg's have valid origins. Unless a good reason can be found for the check, I agree with John here. Doug