From owner-svn-src-stable-10@freebsd.org Thu Dec 31 20:38:54 2015 Return-Path: Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 23362A5679C; Thu, 31 Dec 2015 20:38:54 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x236.google.com (mail-pf0-x236.google.com [IPv6:2607:f8b0:400e:c00::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EF3691A1C; Thu, 31 Dec 2015 20:38:53 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x236.google.com with SMTP id 65so115375688pff.3; Thu, 31 Dec 2015 12:38:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=n9QVxbl6YeVq3HSaUZaaQTJK0cGIk0LIEnOOEEY1c3A=; b=sg5QJmmRe89BKMygu3RFlTtsCJCRB185g/4asqLLnBO1HAveIHWtPVzId7MOBA9G63 nY5Wj5HaotU1jNSwZRJK/1nz2PA0m1ebDhzSE9yqnoq/IcImWtNy60lgMDyhWX0a9FY7 CIe7jOvHC19sGKJb8woUyyYxBslVnwyYJbboQR3/vj+ODzUIDVfLsyZilIzfz3tcWVkM veoLQFeRLix4kU0Y0aunxur34M9UNmVsNITeC/782FESwNnsb6PImxEq8QG9HbfztDpp qHZGN51qpMicG9xTiNelMHQWrvXYGpdJ6XtSqCBxnX5YtJcT9TZePRbQpP443vzPIq9T WTWg== X-Received: by 10.98.14.69 with SMTP id w66mr73202279pfi.67.1451594333616; Thu, 31 Dec 2015 12:38:53 -0800 (PST) Received: from ?IPv6:2601:601:800:126d:9910:6b8e:28b:6700? ([2601:601:800:126d:9910:6b8e:28b:6700]) by smtp.gmail.com with ESMTPSA id u26sm47895540pfa.86.2015.12.31.12.38.51 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 31 Dec 2015 12:38:52 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r292975 - stable/10/sys/dev/pci From: NGie Cooper In-Reply-To: <2893860.oDiG4KQizb@ralph.baldwin.cx> Date: Thu, 31 Dec 2015 12:38:50 -0800 Cc: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <633EF3EE-0899-45A1-B12C-CC2290A1FA29@gmail.com> References: <201512310355.tBV3t2VG040656@repo.freebsd.org> <2893860.oDiG4KQizb@ralph.baldwin.cx> To: John Baldwin X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Dec 2015 20:38:54 -0000 > On Dec 31, 2015, at 08:42, John Baldwin wrote: >=20 > On Thursday, December 31, 2015 03:55:02 AM Garrett Cooper wrote: >> Author: ngie >> Date: Thu Dec 31 03:55:02 2015 >> New Revision: 292975 >> URL: https://svnweb.freebsd.org/changeset/base/292975 >>=20 >> Log: >> MFC r278860: >> r278860 (by jmg): >>=20 >> remove NULL check as M_WAITOK will not return NULL >>=20 >> Reviewed by: jhb >> Sponsored by: FreeBSD Foundation >=20 > Including the metadata from the HEAD commit in the MFC can be = misleading, and > I think it is best ommitted. For example, I did not review this MFC = (and > reviewing MFC's in their own right matters since they may require = additional > work than commits to HEAD due to ABI concerns), nor did the Foundation = sponsor > the MFC. Rather, I think MFCs should only specify metadata related to = the > actual merge itself. Agreed. I=E2=80=99ve changed my mfc_log script to skip over some more = unnecessary svn log metadata: = https://github.com/yaneurabeya/scratch/commit/4f897efb96f96f951ff3909857f6= 7e63b24b733a . Thanks :)! -NGie=