From owner-svn-ports-head@freebsd.org  Tue Jul 11 08:35:53 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B20CD991D2;
 Tue, 11 Jul 2017 08:35:53 +0000 (UTC)
 (envelope-from madpilot@FreeBSD.org)
Received: from mail.madpilot.net (grunt.madpilot.net [78.47.145.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 491EC66A32;
 Tue, 11 Jul 2017 08:35:52 +0000 (UTC)
 (envelope-from madpilot@FreeBSD.org)
Received: from mail (mail [192.168.254.3])
 by mail.madpilot.net (Postfix) with ESMTP id 3x6Fd51cvTzb5W;
 Tue, 11 Jul 2017 10:30:01 +0200 (CEST)
Received: from mail.madpilot.net ([192.168.254.3])
 by mail (mail.madpilot.net [192.168.254.3]) (amavisd-new, port 10024)
 with ESMTP id xbR6klFPnod5; Tue, 11 Jul 2017 10:29:55 +0200 (CEST)
Received: from marvin.madpilot.net (micro.madpilot.net [88.149.173.206])
 by mail.madpilot.net (Postfix) with ESMTPSA;
 Tue, 11 Jul 2017 10:29:55 +0200 (CEST)
Subject: Re: svn commit: r445400 - in head/deskutils/calibre: . files
To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
References: <201707091013.v69ADnGE029028@repo.freebsd.org>
 <61f7e706-5c92-e4e4-ab5f-a952aa42c89b@FreeBSD.org>
From: Guido Falsi <madpilot@FreeBSD.org>
Message-ID: <98932617-a181-76b7-7392-5f04ccc6d43e@FreeBSD.org>
Date: Tue, 11 Jul 2017 10:29:55 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <61f7e706-5c92-e4e4-ab5f-a952aa42c89b@FreeBSD.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jul 2017 08:35:53 -0000

On 07/11/17 08:41, Mathieu Arnold wrote:
> Le 09/07/2017 à 12:13, Guido Falsi a écrit :
>> +python_OLD_CMD=	"/usr/bin/env python" /bin/python /usr/bin/python /usr/local/bin/python \
>> +		"/usr/bin/env python2" /bin/python2 /usr/bin/python2 /usr/local/bin/python2
> 
> All the values on the first line already are present in python_OLD_CMD,
> so now, they are here twice:
> 
> $ make -V python_OLD_CMD
> "/usr/bin/env python" /bin/python /usr/bin/python /usr/local/bin/python 
> "/usr/bin/env python2" /bin/python2 /usr/bin/python2
> /usr/local/bin/python2 "/usr/bin/env python" /bin/python /usr/bin/python
> /usr/local/bin/python
> 
> 
> You should remove them and only add values that are not already there.
> 

You're definitely right, sorry for the misuse of the variable. I did not
properly check how the content was being used and assumed, wrongly, I
would be overriding the defaults.

Thanks, I'll fix it shortly.

-- 
Guido Falsi <madpilot@FreeBSD.org>