From owner-freebsd-current@freebsd.org Sat Jun 2 17:36:50 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E324FD5D20 for ; Sat, 2 Jun 2018 17:36:50 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DF1296E535 for ; Sat, 2 Jun 2018 17:36:49 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (Seawolf.HML3.ScaleEngine.net [209.51.186.28]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 6FA381F72A for ; Sat, 2 Jun 2018 17:36:49 +0000 (UTC) Subject: Re: Proper way to remove never used ioctls To: freebsd-current@freebsd.org References: <3ea085128a4e677a4d4150be18b366bd@kondratyev.su> From: Allan Jude Openpgp: preference=signencrypt Autocrypt: addr=allanjude@freebsd.org; prefer-encrypt=mutual; keydata= xsFNBFVwZcYBEADwrZDH0xe0ZVjc9ORCc6PcBLwS/RTXA6NkvpD6ea02pZ8lPOVgteuuugFc D34LdDbiWr+479vfrKBh+Y38GL0oZ0/13j10tIlDMHSa5BU0y6ACtnhupFvVlQ57+XaJAb/q 7qkfSiuxVwQ3FY3PL3cl1RrIP5eGHLA9hu4eVbu+FOX/q/XVKz49HaeIaxzo2Q54572VzIo6 C28McX9m65UL5fXMUGJDDLCItLmehZlHsQQ+uBxvODLFpVV2lUgDR/0rDa0B9zHZX8jY8qQ7 ZdCSy7CwClXI054CkXZCaBzgxYh/CotdI8ezmaw7NLs5vWNTxaDEFXaFMQtMVhvqQBpHkfOD 7rjjOmFw00nJL4FuPE5Yut0CPyx8vLjVmNJSt/Y8WxxmhutsqJYFgYfWl/vaWkrFLur/Zcmz IklwLw35HLsCZytCN5A3rGKdRbQjD6QPXOTJu0JPrJF6t2xFkWAT7oxnSV0ELhl2g+JfMMz2 Z1PDmS3NRnyEdqEm7NoRGXJJ7bgxDbN+9SXTyOletqGNXj/bSrBvhvZ0RQrzdHAPwQUfVSU2 qBhQEi2apSZstgVNMan0GUPqCdbE2zpysg+zT7Yhvf9EUQbzPL4LpdK1llT9fZbrdMzEXvEF oSvwJFdV3sqKmZc7b+E3PuxK6GTsKqaukd/3Cj8aLHG1T1im1QARAQABzSJBbGxhbiBKdWRl IDxhbGxhbmp1ZGVAZnJlZWJzZC5vcmc+wsF/BBMBAgApBQJVcGXGAhsjBQkSzAMABwsJCAcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQGZU1PhKYC34Muw/+JOKpSfhhysWFYiRXynGRDe07 Z6pVsn7DzrPUMRNZfHu8Uujmmy3p2nx9FelIY9yjd2UKHhug+whM54MiIFs90eCRVa4XEsPR 4FFAm0DAWrrb7qhZFcE/GhHdRWpZ341WAElWf6Puj2devtRjfYbikvj5+1V1QmDbju7cEw5D mEET44pTuD2VMRJpu2yZZzkM0i+wKFuPxlhqreufA1VNkZXI/rIfkYWK+nkXd9Efw3YdCyCQ zUgTUCb88ttSqcyhik/li1CDbXBpkzDCKI6I/8fAb7jjOC9LAtrZJrdgONywcVFoyK9ZN7EN AVA+xvYCmuYhR/3zHWH1g4hAm1v1+gIsufhajhfo8/wY1SetlzPaYkSkVQLqD8T6zZyhf+AN bC7ci44UsiKGAplB3phAXrtSPUEqM86kbnHg3fSx37kWKUiYNOnx4AC2VXvEiKsOBlpyt3dw WQbOtOYM+vkfbBwDtoGOOPYAKxc4LOIt9r+J8aD+gTooi9Eo5tvphATf9WkCpl9+aaGbSixB tUpvQMRnSMqTqq4Z7DeiG6VMRQIjsXDSLJEUqcfhnLFo0Ko/RiaHd5xyAQ4DhQ9QpkyQjjNf /3f/dYG7JAtoD30txaQ5V8uHrz210/77DRRX+HJjEj6xCxWUGvQgvEZf5XXyxeePvqZ+zQyT DX61bYw6w6bOwU0EVXBlxgEQAMy7YVnCCLN4oAOBVLZ5nUbVPvpUhsdA94/0/P+uqCIh28Cz ar56OCX0X19N/nAWecxL4H32zFbIRyDB2V/MEh4p9Qvyu/j4i1r3Ex5GhOT2hnit43Ng46z5 29Es4TijrHJP4/l/rB2VOqMKBS7Cq8zk1cWqaI9XZ59imxDNjtLLPPM+zQ1yE3OAMb475QwN UgWxTMw8rkA7CEaqeIn4sqpTSD5C7kT1Bh26+rbgJDZ77D6Uv1LaCZZOaW52okW3bFbdozV8 yM2u+xz2Qs8bHz67p+s+BlygryiOyYytpkiK6Iy4N7FTolyj5EIwCuqzfk0SaRHeOKX2ZRjC qatkgoD/t13PNT38V9tw3qZVOJDS0W6WM8VSg+F+bkM9LgJ8CmKV+Hj0k3pfGfYPOZJ/v18i +SmZmL/Uw2RghnwDWGAsPCKu4uZR777iw7n9Io6Vfxndw2dcS0e9klvFYoaGS6H2F13Asygr WBzFNGFQscN4mUW+ZYBzpTOcHkdT7w8WS55BmXYLna+dYer9/HaAuUrONjujukN4SPS1fMJ2 /CS/idAUKyyVVX5vozoNK2JVC1h1zUAVsdnmhEzNPsvBoqcVNfyqBFROEVLIPwq+lQMGNVjH ekLTKRWf59MEhUC2ztjSKkGmwdg73d6xSXMuq45EgIJV2wPvOgWQonoHH/kxABEBAAHCwWUE GAECAA8FAlVwZcYCGwwFCRLMAwAACgkQGZU1PhKYC34w5A//YViBtZyDV5O+SJT9FFO3lb9x Zdxf0trA3ooCt7gdBkdnBM6T5EmjgVZ3KYYyFfwXZVkteuCCycMF/zVw5eE9FL1+zz9gg663 nY9q2F77TZTKXVWOLlOV2bY+xaK94U4ytogOGhh9b4UnQ/Ct3+6aviCF78Go608BXbmF/GVT 7uhddemk7ItxM1gE5Hscx3saxGKlayaOsdPKeGTVJCDEtHDuOc7/+jGh5Zxpk/Hpi+DUt1ot 8e6hPYLIQa4uVx4f1xxxV858PQ7QysSLr9pTV7FAQ18JclCaMc7JWIa3homZQL/MNKOfST0S 2e+msuRwQo7AnnfFKBUtb02KwpA4GhWryhkjUh/kbVc1wmGxaU3DgXYQ5GV5+Zf4kk/wqr/7 KG0dkTz6NLCVLyDlmAzuFhf66DJ3zzz4yIo3pbDYi3HB/BwJXVSKB3Ko0oUo+6/qMrOIS02L s++QE/z7K12CCcs7WwOjfCYHK7VtE0Sr/PfybBdTbuDncOuAyAIeIKxdI2nmQHzl035hhvQX s4CSghsP319jAOQiIolCeSbTMD4QWMK8RL/Pe1FI1jC3Nw9s+jq8Dudtbcj2UwAP/STUEbJ9 5rznzuuhPjE0e++EU/RpWmcaIMK/z1zZDMN+ce2v1qzgV936ZhJ3iaVzyqbEE81gDxg3P+IM kiYh4ZtPB4Q= Message-ID: Date: Sat, 2 Jun 2018 13:36:49 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SduJM6ALE2xb4qIQyBnyMJ5byptvH4Enk" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jun 2018 17:36:50 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SduJM6ALE2xb4qIQyBnyMJ5byptvH4Enk Content-Type: multipart/mixed; boundary="X95spYZdoIBGAr6EMZBRnjXOSCVoVHvnt"; protected-headers="v1" From: Allan Jude To: freebsd-current@freebsd.org Message-ID: Subject: Re: Proper way to remove never used ioctls References: <3ea085128a4e677a4d4150be18b366bd@kondratyev.su> In-Reply-To: --X95spYZdoIBGAr6EMZBRnjXOSCVoVHvnt Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018-06-02 11:03, Warner Losh wrote: > On Sat, Jun 2, 2018 at 7:33 AM, Vladimir Kondratyev > wrote: >=20 >> Hi, >> >> Our sys/mouse.h header has a definition of MOUSE_GETVARS and MOUSE_SET= VARS >> ioctls which are not documented and only stubbed in a few drivers: mse= (4), >> psm(4) and syscon's sysmouse(4). The only exception is MOUSE_GETVARS >> implemented in psm(4) >> >> Given the fact that they were introduced 20 years ago, implementation = was >> never completed and googling on them shows no traces of usage in index= ed >> universe, is it acceptable to just drop both defines and implementatio= n >> w.o. leaving any COMPAT_FREEBSD shims? >=20 >=20 > I'd prepare a patch just removing them. I'd then send that patch to the= > ports mgr team and request a exp-run. Details for that can be found in > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/p= orts.html >=20 > Once that's done, submit a Phabricator review and send me email. I'll m= ake > sure it gets pushed in if there's no objections. >=20 > Warner > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.o= rg" >=20 This indeed seems to be the correct approach. The exp-run will compile the entire ports tree against the patched base system, and identify any 3rd party software that fails to compile because of the change. --=20 Allan Jude --X95spYZdoIBGAr6EMZBRnjXOSCVoVHvnt-- --SduJM6ALE2xb4qIQyBnyMJ5byptvH4Enk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJbEtWxAAoJEBmVNT4SmAt+GRMP/RzO/9F87F6incGpd1y1nun1 20HPznyAq1ARJMjPdkQqL7A/CwP07nmo4BqS3p8bw+oTkTA/el/ifArxz2Cjj4LA Q/4I25uInBpm3sh+IIAcX3nAmwvrE6yoG+WK5aycEqz87TRQDatR7FdJ+jWRj2Ht oiJhK2I2wY5yYN/YUwERcNBp3qonfzOnGATJ2gecO56kNiVWommi4P6PpVg83OpA dmc2/e9LWirXK/ZRLHQnkfYl0M+NY7eGdK+etW1WAk50T4+qM1h6PtkqYkVskLz9 zELH1miEfpylvVynVVw94U7IGWwdjNAS8EvGGcD8k0JsXpTXOC4iAfVhYXL859+W MvZMRpRe1T7v2HxxkRjoBiFjnWy4oKJ6Nxe5UZNjqOzjKhQckK8f20KAQe5P9fjQ JbeRn0Hwl9BJrFxfQ5KfQ1ow0bJRR/3G5ckqUU8ibrrYeZZM369NQoJ9cMitNon5 KXKL5jnIch5+XaKcC+haofWsBzgefVYSljrysIKvREc5eSsg6KaZTRuJLKz6+/RM N7gFTSd4yymGfjRiqDR4YbTH65DMHcR8BBM0mgroHLhhrApemt9H/cxdzP+II/ty N1N79jUUdSjowsNxSN2LJ4JlcDh0R8QMLaMwRIeK6zdi0TDFZD3HjOjq5DLcg30G mkfTLOoWIhMt1LyillAJ =WGNY -----END PGP SIGNATURE----- --SduJM6ALE2xb4qIQyBnyMJ5byptvH4Enk--