From owner-svn-src-all@freebsd.org Sun Feb 23 04:02:27 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 808BF257FAC; Sun, 23 Feb 2020 04:02:27 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48QBNg2C7Gz4KfC; Sun, 23 Feb 2020 04:02:27 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-qt1-f196.google.com with SMTP id l21so4327423qtr.8; Sat, 22 Feb 2020 20:02:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f8FEvJdea+PZHJ+K1fkomfxnS8AvXb15opxPI/K9zcM=; b=qBZZZ4eLmMzOr0Qtaow1oSKeXuf6OlCsSg3ou+7TFHKuycaktOmxJQYuUKkpQ8s7Ym TKmepvioobmtNDVEMlp7a9CLHMM8+KMAGpeIc8BlOVopzSFq+A8N+8lkJIJi0TInTlUv FwhygZ9WX5U32/Ki3h1WUZjHmKFi/9VIZ/S3u9bzwrIOMFOLKiwST9p9fAH1zFaFziek cjM821Lj8aeka2QPcr7RNYvqp00n0HsXm7Auhu7VQ+cn0gXisia8Xn8ju7IaCIvL/W1D KVh7C4NGV7W1xq/wSXgBNKEEfUeGqVGeopayGo9GNunKJIO6ejbiH8gObRYVgcBEMCr7 eJKw== X-Gm-Message-State: APjAAAVU29AcUKNUxyV6fORq+SECUzRZXkWTyZUWjhz55VWaHy1uUga2 dWKgh8JIlVadXHrNBpJ56oBJ30/4oM4= X-Google-Smtp-Source: APXvYqwVL3iI85mm1ijuEPJ38FZusHSWgVFOkWmjnN5zjX1+GtABul/SOp2QlAse1/ES7EBxKxWYtg== X-Received: by 2002:aed:3f77:: with SMTP id q52mr40363767qtf.248.1582430545691; Sat, 22 Feb 2020 20:02:25 -0800 (PST) Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com. [209.85.160.174]) by smtp.gmail.com with ESMTPSA id i16sm3937769qkh.120.2020.02.22.20.02.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Feb 2020 20:02:25 -0800 (PST) Received: by mail-qt1-f174.google.com with SMTP id i23so4347597qtr.5; Sat, 22 Feb 2020 20:02:25 -0800 (PST) X-Received: by 2002:ac8:5510:: with SMTP id j16mr40409420qtq.262.1582430545124; Sat, 22 Feb 2020 20:02:25 -0800 (PST) MIME-Version: 1.0 References: <202002230332.01N3WCRn083904@repo.freebsd.org> In-Reply-To: From: Ryan Libby Date: Sat, 22 Feb 2020 20:02:14 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r358257 - in head/sys: kern sys To: Kyle Evans Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48QBNg2C7Gz4KfC X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Feb 2020 04:02:27 -0000 On Sat, Feb 22, 2020 at 7:53 PM Kyle Evans wrote: > > On Sat, Feb 22, 2020 at 9:32 PM Ryan Libby wrote: > > > > Author: rlibby > > Date: Sun Feb 23 03:32:11 2020 > > New Revision: 358257 > > URL: https://svnweb.freebsd.org/changeset/base/358257 > > > > Log: > > vfs: quiet -Wwrite-strings > > > > Reviewed by: kib, markj > > Differential Revision: https://reviews.freebsd.org/D23797 > > > > Only tangentially related to this, I have a patch in one of my WIP > branches that const-poisons vn_fullpath()'s retbuf parameter, if > that's of any interest. Many consumers will set a default value to a > statically allocated string before passing it in as the retbuf -- I > had a use-case where I'd be trying to do similar but with a function > that actually returns a const char *, but that particular case may not > get committed. > > I can post the patch to phabricator if anyone cares about this -- the > impact on callers isn't actually all that bad, basically just > shuffling around declarations. There's only one case where it ends up > introducing some __DECONST ugliness because the caller writes it out > with uiomove(). > > Thanks, > > Kyle Evans I did notice vn_fullpath when I tried out the build with -Wwrite-strings, and I decided to stay far away from it! Feel free to add me to a review if you decide to post it. In general there was a lot more that was triggered by -Wwrite-strings, and I only touched the stuff that was in sys/kern or sys/vm and that I thought would have quick and non-controversial resolutions.