From owner-svn-src-user@FreeBSD.ORG Fri Apr 6 19:49:46 2012 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 16157106566C; Fri, 6 Apr 2012 19:49:46 +0000 (UTC) (envelope-from attilio@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 01ADA8FC0A; Fri, 6 Apr 2012 19:49:46 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q36Jnju6023609; Fri, 6 Apr 2012 19:49:45 GMT (envelope-from attilio@svn.freebsd.org) Received: (from attilio@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q36Jnj0A023607; Fri, 6 Apr 2012 19:49:45 GMT (envelope-from attilio@svn.freebsd.org) Message-Id: <201204061949.q36Jnj0A023607@svn.freebsd.org> From: Attilio Rao Date: Fri, 6 Apr 2012 19:49:45 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r233958 - user/attilio/vmcontention/sys/vm X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2012 19:49:46 -0000 Author: attilio Date: Fri Apr 6 19:49:45 2012 New Revision: 233958 URL: http://svn.freebsd.org/changeset/base/233958 Log: Free a cached page rather than only removing it. vm_page_cache_remove() should only be used in very little and specific cases (and marked as static likely) where the callers is going to take care also of the page flags appropriately, otherwise one can end up with a corrupted page. Reported by: pho Modified: user/attilio/vmcontention/sys/vm/vnode_pager.c Modified: user/attilio/vmcontention/sys/vm/vnode_pager.c ============================================================================== --- user/attilio/vmcontention/sys/vm/vnode_pager.c Fri Apr 6 18:18:48 2012 (r233957) +++ user/attilio/vmcontention/sys/vm/vnode_pager.c Fri Apr 6 19:49:45 2012 (r233958) @@ -416,7 +416,7 @@ vnode_pager_setsize(vp, nsize) drop = NULL; mtx_lock(&vm_page_queue_free_mtx); if (m->object == object) { - vm_page_cache_remove(m); + vm_page_cache_free(m); if (object->cached_page_count == 0) drop = vp; }