From owner-cvs-all@FreeBSD.ORG Wed Sep 17 12:35:43 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A19516A4B3 for ; Wed, 17 Sep 2003 12:35:43 -0700 (PDT) Received: from mail.speakeasy.net (mail7.speakeasy.net [216.254.0.207]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F82F43FBF for ; Wed, 17 Sep 2003 12:35:40 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 6818 invoked from network); 17 Sep 2003 19:35:36 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 17 Sep 2003 19:35:36 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h8HJZM6Y083532; Wed, 17 Sep 2003 15:35:24 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <1063826489.18459.1.camel@herring.nlsystems.com> Date: Wed, 17 Sep 2003 15:35:24 -0400 (EDT) From: John Baldwin To: Doug Rabson X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Mitsuru IWASAKI Subject: RE: cvs commit: src/sys/dev/acpica acpi_pci.c src/sys/dev/pci pci.c pci_private.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Sep 2003 19:35:43 -0000 On 17-Sep-2003 Doug Rabson wrote: > On Wed, 2003-09-17 at 15:58, John Baldwin wrote: >> On 17-Sep-2003 Mitsuru IWASAKI wrote: >> > iwasaki 2003/09/17 01:32:44 PDT >> > >> > FreeBSD src repository >> > >> > Modified files: >> > sys/dev/acpica acpi_pci.c >> > sys/dev/pci pci.c pci_private.h >> > Log: >> > Add pci_resume() to reestablish interrupt routing after >> > suspend/resume. >> > Especially after hibernation, interrupt routing went back to initial >> > status on some machines. >> >> The values in memory should still be the same, so it should be sufficient >> simply to write back the already existent intline value back to the >> register. IOW, you shouldn't hae to call PCI_ASSIGN_INTERRUPT(), but >> should do something more like: >> >> if (cfg->intpin > 0 && PCI_INTERRUPT_VALID(cfg->intline)) >> pci_write_config(child, PCIR_INTLINE, cfg->intline, 1); >> >> Eventually pci_suspend/resume should be saving and restoring all of the >> header registers and known capability registers for child devices. > > How will this re-establish irq routing? The intline register is just > informative - don't you have to re-program the host chipset via acpi or > pcibios? For the APIC case, there is no programming, it's hardwired on the board. For actual link devices, I'm inclined to think that they should have their own suspend/resume methods at the device level for each link device. This means that the $PIR code would have to be smarter and use link devices like the ACPI code does though. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/