From owner-cvs-all@FreeBSD.ORG Tue Aug 29 16:01:54 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0424F16A4DE; Tue, 29 Aug 2006 16:01:54 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE99143D46; Tue, 29 Aug 2006 16:01:52 +0000 (GMT) (envelope-from keramida@freebsd.org) Received: from gothmog.pc (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.7/8.13.7/Debian-2) with ESMTP id k7TG1YLA028518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 29 Aug 2006 19:01:37 +0300 Received: from gothmog.pc (gothmog [127.0.0.1]) by gothmog.pc (8.13.7/8.13.7) with ESMTP id k7TG1lc0062113; Tue, 29 Aug 2006 19:01:47 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from giorgos@localhost) by gothmog.pc (8.13.7/8.13.7/Submit) id k7TG1l33062112; Tue, 29 Aug 2006 19:01:47 +0300 (EEST) (envelope-from keramida@freebsd.org) Date: Tue, 29 Aug 2006 19:01:47 +0300 From: Giorgos Keramidas To: Remko Lodder Message-ID: <20060829160147.GB61380@gothmog.pc> References: <200608282020.k7SKKded076011@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200608282020.k7SKKded076011@repoman.freebsd.org> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-3.104, required 5, autolearn=not spam, AWL -0.51, BAYES_00 -2.60, UNPARSEABLE_RELAY 0.00) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No Cc: doc-committers@freebsd.org, cvs-doc@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: CVSROOT commitcheck X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2006 16:01:54 -0000 On 2006-08-28 20:20, Remko Lodder wrote: > remko 2006-08-28 20:20:39 UTC > > FreeBSD doc repository > > Modified files: > . commitcheck > Log: > Avoid warning when cvs has only three numbers in its version string. > > Obtained from: src commitcheck fix > Approved by: simon (cvsadm) > > Revision Changes Path > 1.28 +1 -0 CVSROOT/commitcheck GO Remko!!! I've used a similar change in a local CVSROOT/ copy for ages (at least until Oct 2004, AFAICT from the logs here), but I don't remember if I mailed cvsmeisters about it or if it was ever approved: % $ cvs rdiff -u -r1.2 CVSROOT/commitcheck % Index: CVSROOT/commitcheck % diff -u CVSROOT/commitcheck:1.2 CVSROOT/commitcheck:1.8 % --- CVSROOT/commitcheck:1.2 Wed Jul 7 15:40:43 2004 % +++ CVSROOT/commitcheck Tue Oct 5 13:37:14 2004 % @@ -1,7 +1,10 @@ % #!/usr/bin/perl -w % # % -# $Id: commitcheck,v 1.2 2004/07/07 12:40:43 gkeramidas Exp $ % +# $Id: commitcheck,v 1.8 2004/10/05 10:37:14 gkeramidas Exp $ % # % +# Original version: % +# $FreeBSD: CVSROOT-src/commitcheck,v 1.27 2004/09/01 03:12:06 kuriyama Exp $ % + % # This script is the first thing that is run at commit time % # to determine whether the committer has commit priviledges. % # (See CVSROOT/commitinfo). % @@ -43,7 +42,9 @@ % my $VERSTR = `$cfg::PROG_CVS -v`; % $VERSTR =~ s/.*Concurrent\D*(\S*).*/$1/s; % $VERSTR =~ s/\D+/./g; % -my $VERSION = sprintf "%d%02d%02d%02d\n", split /\./, $VERSTR; % +$VERSTR =~ s/\.$/.0/; % +$VERSTR =~ s/$/.0.0.0.0/; % +my $VERSION = sprintf "%d%02d%02d%02d\n", (split /\./, $VERSTR)[0,1,2,3]; % unless ($VERSION && $VERSION >= $cfg::MINCVSVERSION) { % print "The wrong version of CVS is installed (commitcheck)!\n"; % exit 1; Thank you for fixing this to our FreeBSD repo scripts too :-)