From owner-freebsd-bugs@freebsd.org Sat Jul 1 02:08:39 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 141E1DA248D for ; Sat, 1 Jul 2017 02:08:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 01A722968 for ; Sat, 1 Jul 2017 02:08:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v6128c1E047783 for ; Sat, 1 Jul 2017 02:08:38 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 220404] head -r319722 or -r320224 related changes break powerpc production-style kernel operation: bad function pointer Date: Sat, 01 Jul 2017 02:08:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markmi@dsl-only.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jul 2017 02:08:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220404 --- Comment #1 from Mark Millard --- (In reply to Mark Millard from comment #0) Some other supporting code details follow. static struct socket * soalloc(struct vnet *vnet) { struct socket *so; so =3D uma_zalloc(socket_zone, M_NOWAIT | M_ZERO); . . . so->so_rcv.sb_sel =3D &so->so_rdsel; so->so_snd.sb_sel =3D &so->so_wrsel; . . . That so->so_rcv.sb_sel assignment makes so->sol_upcall non-NULL and so appear to be defined for use. And that makes the following code problematical: void solisten_wakeup(struct socket *sol) { if (sol->sol_upcall !=3D NULL) (void )sol->sol_upcall(sol, sol->sol_upcallarg, M_NOWAIT); else { . . . And this code is what is failing on production 32-bit powerpc kernels. There could be more anonymous struct field problems in the union that is in struct socket . I've not checked. I'll note that the only references to sol_upcall are: # grep -r "\sol_upcall !=3D NULL) /usr/src/sys/kern/uipc_socket.c: (void )sol->sol_upcall(sol, sol->sol_upcallarg, M_NOWAIT); /usr/src/sys/kern/uipc_socket.c: so->sol_upcall =3D func; /usr/src/sys/kern/uipc_socket.c: so->sol_upcallarg =3D arg; /usr/src/sys/sys/socketvar.h: so_upcall_t *sol_upcall= ;=20=20=20 /* (e) */ /usr/src/sys/sys/socketvar.h: void *sol_upcall= arg; /* (e) */ None of those assign NULL. If NULL was assigned then ->so_rcv.sb_sel would also become NULL in value. --=20 You are receiving this mail because: You are the assignee for the bug.=