From owner-cvs-src@FreeBSD.ORG Thu Nov 17 14:35:17 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 02E4016A420; Thu, 17 Nov 2005 14:35:17 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from viefep13-int.chello.at (viefep13-int.chello.at [213.46.255.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82B3843D5F; Thu, 17 Nov 2005 14:35:12 +0000 (GMT) (envelope-from stefan@fafoe.narf.at) Received: from wombat.fafoe.narf.at ([213.47.85.26]) by viefep13-int.chello.at (InterMail vM.6.01.04.04 201-2131-118-104-20050224) with ESMTP id <20051117143510.YCTY11640.viefep13-int.chello.at@wombat.fafoe.narf.at>; Thu, 17 Nov 2005 15:35:10 +0100 Received: by wombat.fafoe.narf.at (Postfix, from userid 1001) id CD79D134; Thu, 17 Nov 2005 15:35:08 +0100 (CET) Date: Thu, 17 Nov 2005 15:35:08 +0100 From: Stefan Farfeleder To: Alexander Leidinger Message-ID: <20051117143506.GL584@wombat.fafoe.narf.at> References: <200511150419.jAF4JRUp080869@repoman.freebsd.org> <20051115105128.a5dd001i0ckock0s@netchild.homeip.net> <20051115095801.M61850@fledge.watson.org> <20051115202306.4cf2dcf2.ariff@FreeBSD.org> <20051115124331.GD9996@wombat.fafoe.narf.at> <20051117145139.h0rxsukk74wog4c8@netchild.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051117145139.h0rxsukk74wog4c8@netchild.homeip.net> User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Ariff Abdullah Subject: Re: cvs commit: src/sys/dev/sound/pcm channel.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2005 14:35:17 -0000 On Thu, Nov 17, 2005 at 02:51:39PM +0100, Alexander Leidinger wrote: > Stefan Farfeleder wrote: > > >On Tue, Nov 15, 2005 at 08:23:06PM +0800, Ariff Abdullah wrote: > >>On Tue, 15 Nov 2005 09:58:52 +0000 (GMT) > >>Robert Watson wrote: > > >>> Probably a combination of -Wall and -Werror, which generally > >>> generates a warning along the following lines: > >>> > >>> warning: suggest parentheses around comparison in operand of & > >>> > >>That means, warnings caused by excessive inlining while compiling > >>maestro.c should also break the build if WARNS=1, right? Has anybody > >>encounter and getting annoyed by this? > > > >No, function inlining doesn't change the semantics of expressions. I misread Ariff's question. Please disregard. > So -Wall and -Werror doesn' result in issuing an error for each warning but > instead in an error for warnings, which are issued because the code in > question may change the semantic depending on the change which needs to be > done to get rid of the warning? Whether GCC prints 'warning:' or 'error:' is not changed by -Werror. I'm not sure understand the second part of your question. The warning is issued because a & b == c is parsed as a & (b == c). Stefan