Date: Tue, 12 Nov 2024 07:42:43 -0700 From: Alan Somers <asomers@freebsd.org> To: Nuno Teixeira <eduardo@freebsd.org> Cc: gnome@freebsd.org, ashish@freebsd.org, dmgk@freebsd.org Subject: Re: Requiring SSE2 by default for i386 Message-ID: <CAOtMX2hqUa3SHeUvkpqqhopxW9TrwBA1mfFR2JZbaTos5b99Mw@mail.gmail.com> In-Reply-To: <CAFDf7UL0Uqtf=5pMif0rkqHS=5PF%2BcWppm5P0-i59JUURdtZCw@mail.gmail.com> References: <CAOtMX2gua9NBY-_BB8rozaGvZJjg9tCkbM7XaWj5Q-fSKrM32w@mail.gmail.com> <CAFDf7UJ7XDKwQUg20WQkJCBf=ZF02dztrrKa=YQC0OycFa925Q@mail.gmail.com> <CAOtMX2j2rtpgp=yU1d-bzUSe3jq=UnxO8_O%2B4aHh6ORnMW_gdQ@mail.gmail.com> <CAFDf7UJ58-gE_KGM4tv3O78RWngQs-vHOxZMAKvn0d7yF6JNwA@mail.gmail.com> <CAOtMX2hzFy7_iVs0=voSm1cJfskEO4ezCJUGcKm6w7=4jewDxw@mail.gmail.com> <CAFDf7UJfHyNT2Rxh7wvByADOHE4ALu2ywMs8T5wfHpGei2tOEQ@mail.gmail.com> <CAOtMX2gKMtFh5=OntRcaPP5taMRcs1-%2B5_HUKg6S60vBAMB3-w@mail.gmail.com> <CAFDf7UL0Uqtf=5pMif0rkqHS=5PF%2BcWppm5P0-i59JUURdtZCw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
There's no connection between this port and Rust. The only connection is that "Due to Rust, more than 500 ports now require SSE2 by default on i386, so we may as well make it on-by-default for other ports too". Your commit LGTM. On Tue, Nov 12, 2024 at 2:23=E2=80=AFAM Nuno Teixeira <eduardo@freebsd.org>= wrote: > > Hello, > > As upstream defaults to use SSE2 on amd64/i386 I'm reproducing it on port= . > I still don't get what this port has to do with rust SSE2 i386 requiremen= t as it doesn't use rust code, but I think we will get some performance imp= rovements. > > If you need any change on port, please feel free to change it. > > https://cgit.freebsd.org/ports/commit/?id=3D78b13cb9ecb8c0c0f59e09ba8d026= 4d023d6f688 > > Cheers, > > > Alan Somers <asomers@freebsd.org> escreveu (segunda, 11/11/2024 =C3=A0(s)= 20:50): >> >> Sounds good. >> >> On Mon, Nov 11, 2024 at 1:30=E2=80=AFPM Nuno Teixeira <eduardo@freebsd.o= rg> wrote: >> > >> > Ah, sure. >> > >> > I will add OPTIONS_DEFAULT=3DSSE2 and check if it will be problems for= amd64 and aarch64. >> > If everything ok then use this option since upstream default is SSE2 o= n by default. >> > >> > Sorry as I misread past email. >> > >> > Alan Somers <asomers@freebsd.org> escreveu (segunda, 11/11/2024 =C3=A0= (s) 16:25): >> >> >> >> I don't know what that "QMAKE_ON" part means. But when I do "make >> >> config", it shows the SSE2 option disabled by default. >> >> >> >> On Mon, Nov 11, 2024 at 5:20=E2=80=AFAM Nuno Teixeira <eduardo@freebs= d.org> wrote: >> >> > >> >> > (...) >> >> > >> >> > Just took a look at port Makefile and it's alleady set: >> >> > >> >> > OPTIONS_DEFINE=3D SSE2 >> >> > SSE2_DESC=3D Enable SSE2 optimization >> >> > SSE2_QMAKE_ON=3D CONFIG+=3Dsse2 >> >> > SSE2_QMAKE_OFF=3D CONFIG+=3Dno-sse2 >> >> > >> >> > This port does not have rust code. >> >> > >> >> > Alan Somers <asomers@freebsd.org> escreveu (domingo, 10/11/2024 =C3= =A0(s) 15:51): >> >> >> >> >> >> On Sun, Nov 10, 2024 at 7:00=E2=80=AFAM Nuno Teixeira <eduardo@fre= ebsd.org> wrote: >> >> >> > >> >> >> > Hello, >> >> >> > >> >> >> >> graphics/fraqtive >> >> >> > >> >> >> > >> >> >> > https://github.com/mimecorg/fraqtive/blob/02914797f47d26c4098f4a= 3a945716b13998a8cc/INSTALL#L43 >> >> >> > Upstream says SSE2 is enabled by default. >> >> >> > >> >> >> > What should we do here? >> >> >> >> >> >> Just set OPTIONS_DEFAULT_i386=3DSSE2 or OPTIONS_DEFAULT=3DSSE2 in = the port Makefile. >> >> > >> >> > >> >> > >> >> > -- >> >> > Nuno Teixeira >> >> > FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org >> > >> > >> > >> > -- >> > Nuno Teixeira >> > FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org > > > > -- > Nuno Teixeira > FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2hqUa3SHeUvkpqqhopxW9TrwBA1mfFR2JZbaTos5b99Mw>