Date: Tue, 15 Dec 2015 23:58:09 +0100 From: Kristof Provost <kp@FreeBSD.org> To: Steven Hartland <smh@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292275 - in head/sys: net netinet netinet6 Message-ID: <1016D8B2-F850-44B9-B773-632BD9ABC95D@FreeBSD.org> In-Reply-To: <8CEE530E-C08D-4BD1-B908-8EBBCEEAD1CD@FreeBSD.org> References: <201512151602.tBFG2BTX089543@repo.freebsd.org> <8CEE530E-C08D-4BD1-B908-8EBBCEEAD1CD@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 15 Dec 2015, at 23:15, Kristof Provost <kp@FreeBSD.org> wrote:
> Based on the arp_announce() in the backtrace this commit looks like a =
possible cause.
I see this in arp_announce():=20
KP: arp_announce() ifp->if_addr =3D 0
So that explains why we panic in 'lladdr =3D IF_LLADDR(ifp);=E2=80=99.
I=E2=80=99ve done a very quick hack:
diff --git a/sys/netinet/if_ether.c b/sys/netinet/if_ether.c
index 2214542..9b25356 100644
--- a/sys/netinet/if_ether.c
+++ b/sys/netinet/if_ether.c
@@ -1246,9 +1246,15 @@ arp_announce(struct ifnet *ifp)
}
IF_ADDR_RUNLOCK(ifp);
- lladdr =3D IF_LLADDR(ifp);
- for (i =3D 0; i < cnt; i++) {
- arp_announce_addr(ifp, head + i, lladdr);
+ printf("KP: %s() ifp =3D %p\n", __FUNCTION__, ifp);
+ printf("KP: %s() ifp->if_addr =3D %p\n", __FUNCTION__, =
ifp->if_addr);
+
+ if (ifp->if_addr) {
+ printf("KP: %s() ifp->if_addr->ifa_addr =3D %p\n", =
__FUNCTION__, ifp->if_addr->ifa_addr);
+ lladdr =3D IF_LLADDR(ifp);
+ for (i =3D 0; i < cnt; i++) {
+ arp_announce_addr(ifp, head + i, lladdr);
+ }
}
free(head, M_TEMP);
}
With this patch the device boots. I haven=E2=80=99t been able to verify =
if everything works because of a different issue ("Shared object =
"lib80211.so.1" not found, required by =E2=80=9Cifconfig=E2=80=9D=E2=80=9D=
, no doubt just a small problem with the freebsd-wifi-build scripts).
Regards,
Kristof=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1016D8B2-F850-44B9-B773-632BD9ABC95D>