From owner-cvs-all Wed May 31 10:23:35 2000 Delivered-To: cvs-all@freebsd.org Received: from gidora.zeta.org.au (gidora.zeta.org.au [203.26.10.25]) by hub.freebsd.org (Postfix) with SMTP id 9B59837BBF0 for ; Wed, 31 May 2000 10:23:18 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: (qmail 31949 invoked from network); 31 May 2000 17:23:14 -0000 Received: from unknown (HELO bde.zeta.org.au) (203.2.228.102) by gidora.zeta.org.au with SMTP; 31 May 2000 17:23:14 -0000 Date: Thu, 1 Jun 2000 03:23:10 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Mike Smith Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/quot quot.c In-Reply-To: <200005311656.JAA05296@mass.cdrom.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 31 May 2000, Mike Smith wrote: > > On Tue, 30 May 2000, Mike Smith wrote: > > > > > There are a heap of these that use "/dev" rather than PATH_DEV. What's > > > the feeling on cleaning them all up? > > > > Hard-coded directories are almost as evil as hard-coded modifiers for > > device names :-). > > 8) This sounds like an argument for sysctlbyname("path_dev") to me... I only meant complete hard-coding of the strings. If everything used macros for paths, then it might be possible to support dynamic paths by #defining the macros as function calls. > How do you feel about ANSI string concatenation, eg: > > open(PATH_DEV "rmt0", ... This would break K&R support :-), and wouldn't work in most contexts (the basename is normally from argv[]; for dump(8) it may be from the environment). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message