From nobody Wed Jan 14 00:23:08 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4drRfN4zppz6NvBp for ; Wed, 14 Jan 2026 00:23:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4drRfN4Mvzz3cFP for ; Wed, 14 Jan 2026 00:23:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768350188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uXhUcmSsvGRCUKbvIkFEnuHiypb5EAbMLvhSgcsCmFM=; b=hNXUhlq2cjF4fU9DEBI6GboVIoAmNqZecCXBTwxdnCvi81PIFd41hAcmJgZCFL2c2c/XSM V7T/L5RYQ9Zfd4dQ7QpKtlUge0gsAWnVXCtGv5vbm4Pn5mJ1dupcTCJnpzjNEu63l7+k0U AEmfTSMK4IwR9tKzgrp8Nib2A6jaNUl8lr0r9c2lAEe8tTdNZZ8WHOA3y/hmdJV0tuU7kW zvhMyIRNHp7jVoquKQoMw8vgiC+NrC1u8ZRyN0pTU7NhPagAwz0Xe3xwuHj6Rb4G/fC7Ay m1rcIjUtW/MFrClEHFJgGo8Kcalf3WWBbhrApqAprxth07nV1gO1HWq88FSDLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768350188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uXhUcmSsvGRCUKbvIkFEnuHiypb5EAbMLvhSgcsCmFM=; b=pvPBFgK7fCpKJCFS0mXFhtzdiM65dBiEyHmAsJ0BwsCYB2KQM2j9Fynao4xJvKipp8ljLT Ikdq0V2aGi9tv+8Kq84delAnoOnUXFd3PagZJ8A95WXoxlqd5fvtUr0nyXy9eCjX1hqmzi dIowPg1U+34O0o9OhuVLrwFe6LZHXGwPbCRnkpLkb1UQY1K3yxH4c/gBSZfcib/rtXx/SO uQenRenLFUxi4B6gH0yP/FckLQSl9RzJzvedG0YeBCBtvKMsaaAKVCTh9AiFBN5+X8KRWX 7ZLP1bjZpba/IKewLYc+xAcsjsD0wTzZIzx+DkgL9LBone6zgX0JkbZ+2P/U8g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768350188; a=rsa-sha256; cv=none; b=fZ7hp2q743x7X/yHSTASekgoBzDahnqzuTd/cHvAazyJeDH9HI0YXq63Y6IknW3dMSX9y7 MhBvYg6Fr3Ua8T1FUKki5QIbChNr2X1hZ8rZcIYX1LD7G/l0d1itMlB4iYAuz8uKvq5AOz KRhHuFOntSwEXyUw2aZhyRGqVk7IjoOc6VpJqW4+KJW9ASXoWuVKP6Vpaz/oHDEwYLSv9m GizWdUCITpU4PisqU3+gUoeBzPdYUd/PWVpGBtO5lEoWc8any+quRfyjbB99/czIT3cCsu +NE6JSI7vdwLQx2pMByTKprFQ/5odQPQjx9W7powzH2QFj+JbGl9bnwZ03uI2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4drRfN3hDQzbYl for ; Wed, 14 Jan 2026 00:23:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3d839 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 14 Jan 2026 00:23:08 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Quent=?utf-8?Q?in Th=C3=A9?=bault From: Kyle Evans Subject: git: 5e1c7867e1b9 - main - vt(4): allow up to _SIG_MAXSIG (128) for VT_SETMODE List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5e1c7867e1b9a8abe7307d01087cddc057e39859 Auto-Submitted: auto-generated Date: Wed, 14 Jan 2026 00:23:08 +0000 Message-Id: <6966e1ec.3d839.7271f439@gitrepo.freebsd.org> The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=5e1c7867e1b9a8abe7307d01087cddc057e39859 commit 5e1c7867e1b9a8abe7307d01087cddc057e39859 Author: Quentin Thébault AuthorDate: 2026-01-14 00:14:22 +0000 Commit: Kyle Evans CommitDate: 2026-01-14 00:15:30 +0000 vt(4): allow up to _SIG_MAXSIG (128) for VT_SETMODE VT_SETMODE ioctl currently checks the provided signal numbers with its own ISSIGVALID macro that uses NSIG (32) as a maximum, although the code that will actually send the signal in sys/kern/kern_sig.c uses _SIG_VALID which allows up to _SIG_MAXSIG (128). This change aligns the vt code with the kernel internals and enables the use of higher signal numbers so that applications are not limited to SIGUSR1 and SIGUSR2 for vt release and acquire signals. Signed-off-by: Quentin Thébault Reviewed by: emaste, imp, kevans Differential Revision: https://reviews.freebsd.org/D53615 --- sys/dev/vt/vt.h | 1 - sys/dev/vt/vt_core.c | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/sys/dev/vt/vt.h b/sys/dev/vt/vt.h index 8e35a81bc101..4abe99e4ab13 100644 --- a/sys/dev/vt/vt.h +++ b/sys/dev/vt/vt.h @@ -81,7 +81,6 @@ #else #define DPRINTF(_l, ...) do {} while (0) #endif -#define ISSIGVALID(sig) ((sig) > 0 && (sig) < NSIG) #define VT_SYSCTL_INT(_name, _default, _descr) \ int vt_##_name = (_default); \ diff --git a/sys/dev/vt/vt_core.c b/sys/dev/vt/vt_core.c index 5e8f7b1d0bb7..a6a5f0eeff9d 100644 --- a/sys/dev/vt/vt_core.c +++ b/sys/dev/vt/vt_core.c @@ -3046,9 +3046,9 @@ skip_thunk: DPRINTF(5, "reset WAIT_ACQ, "); return (0); } else if (mode->mode == VT_PROCESS) { - if (!(ISSIGVALID(mode->relsig) && - ISSIGVALID(mode->acqsig) && - (mode->frsig == 0 || ISSIGVALID(mode->frsig)))) { + if (!(_SIG_VALID(mode->relsig) && + _SIG_VALID(mode->acqsig) && + (mode->frsig == 0 || _SIG_VALID(mode->frsig)))) { DPRINTF(5, "error EINVAL\n"); return (EINVAL); }