From owner-freebsd-current@FreeBSD.ORG Wed Aug 18 13:46:28 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B84E1065672; Wed, 18 Aug 2010 13:46:28 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 02C258FC19; Wed, 18 Aug 2010 13:46:27 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o7IDkN50035699 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 18 Aug 2010 16:46:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o7IDkNYo015205; Wed, 18 Aug 2010 16:46:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o7IDkNKs015204; Wed, 18 Aug 2010 16:46:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 18 Aug 2010 16:46:23 +0300 From: Kostik Belousov To: pluknet Message-ID: <20100818134623.GU2396@deviant.kiev.zoral.com.ua> References: <20100816185456.GU2396@deviant.kiev.zoral.com.ua> <20100817160445.GO2396@deviant.kiev.zoral.com.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hD4TXpRh/LvuDKsa" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.7 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_05, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: FreeBSD Current Subject: Re: LOR on nfs: vfs_vnops.c:301 kern_descrip.c:1580 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2010 13:46:28 -0000 --hD4TXpRh/LvuDKsa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 18, 2010 at 02:43:19PM +0400, pluknet wrote: > On 18 August 2010 12:07, pluknet wrote: > > On 17 August 2010 20:04, Kostik Belousov wrote: > > > >> > >> Also please take a note of the John' suggestion to use the taskqueue. > > > > I decided to go this road. Thank you both. > > Now I do nfs buildkernel survive and prepare some benchmark results. > > >=20 > So, I modified the patch to defer proc_create() with taskqueue(9). > Below is `time make -j5 buildkernel WITHOUT_MODULES=3Dyes` perf. evaluati= on. > Done on 4-way CPU on clean /usr/obj with /usr/src & /usr/obj both > nfs-mounted over 1Gbit LAN. >=20 > clean old > 1137.985u 239.411s 7:42.15 298.0% 6538+2133k 87+43388io 226pf+0w >=20 > clean new > 1134.755u 240.032s 7:41.25 298.0% 6553+2133k 87+43367io 224pf+0w >=20 > Patch needs polishing, though it generally works. > Not sure if shep_chan (or whatever name it will get) needs locking. As I said yesterday, if several requests to create nfsiod coming one after another, you would loose all but the last. You should put the requests into the list, probably protected by nfs_iod_mtx. --hD4TXpRh/LvuDKsa Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkxr5C8ACgkQC3+MBN1Mb4gUFQCeMGYn5XUfyfY2Bm5SUjJHqSQ5 HBoAoOWMETGNQTdDG0fsNdowHsG1/YXG =CXex -----END PGP SIGNATURE----- --hD4TXpRh/LvuDKsa--