From owner-freebsd-hackers@freebsd.org Thu May 19 04:11:22 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4D667B4116E for ; Thu, 19 May 2016 04:11:22 +0000 (UTC) (envelope-from rwestlun@gmail.com) Received: from mail-qk0-x22c.google.com (mail-qk0-x22c.google.com [IPv6:2607:f8b0:400d:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 08AC01B4D for ; Thu, 19 May 2016 04:11:22 +0000 (UTC) (envelope-from rwestlun@gmail.com) Received: by mail-qk0-x22c.google.com with SMTP id n62so36916783qkc.2 for ; Wed, 18 May 2016 21:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=0h40GWBskqtFcuHjISy8oeQDD/YHae51rmUs0V4nu1k=; b=ABABWmHeoZlJZKLJ5dU9HyAp/Qq3WbHA4OmHfr6+vYACEpxwOnFiBnIh5RetrD9bhl qJxg1iUh+JlWc0cHViu0fRx97D99jnwHfOhms/A/kZbaU9M74eZdUN6ZuK6+xwGdubKT kXsH3uuSZLNIDT8k3A/ABw7gK1P/1kZz00yftmN6i9V8mnWvMVqfAv0P/3QEomkPBS/P jkfEHXuMZ9BewMxivPblDahYVifS5IX145amR+amXRHTXwbMj6i2Vkj2UEI3616S/6ih uJZSrabG57Dbdv3FasjZYRtEGh6TmZxvQ/aEVnbeXhCU+nchYdLKBmZf5ggiMYbD/LB6 yVNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=0h40GWBskqtFcuHjISy8oeQDD/YHae51rmUs0V4nu1k=; b=Zj1hp9FiwGjmQ2XEbQF3a+1bZqdgMhIba3/XERs3mgKuIIhrn4GUX9iQ5uPpzjAFYa zJL50nFD6aB/n/WWtXSCmzL7Dne5GIim1PZn+PZQvdRVgx8R5uoT4NVYU1o/gsqoMrns 1rzByKguJEYGmvPBQbQ+RToMpXm11DiWb+QnkeAYSERiep8xZVxinRlB7YUYhEWDueYo wVnET4JfSPYG/xZCSf60CGcv6pkXSlYglcuFOQDpiRuXidGe+9vhKAK6Rbf6o2xBgxS5 jfdoLtkZpV093yHHDxK/a1R+sHS2Yz0eskacd5Mr/KGmtkg69DFgdy2Bv9aHh93w2R1x CGZg== X-Gm-Message-State: AOPr4FU1WN42mKlMYTtbMbH/7r0Q36bl2u4HzKPIb68aPFWdiF6eBturAVxFuku0/e3fTg== X-Received: by 10.55.68.78 with SMTP id r75mr11722458qka.189.1463631081219; Wed, 18 May 2016 21:11:21 -0700 (PDT) Received: from gmail.com (c-98-216-247-110.hsd1.ma.comcast.net. [98.216.247.110]) by smtp.gmail.com with ESMTPSA id w70sm5797173qhw.22.2016.05.18.21.11.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 May 2016 21:11:20 -0700 (PDT) Date: Thu, 19 May 2016 00:11:18 -0400 From: Randy Westlund To: freebsd-hackers@freebsd.org Subject: What changes are welcome? Message-ID: <20160519041118.GE19887@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IU5/I01NYhRvwH70" Content-Disposition: inline User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 04:11:22 -0000 --IU5/I01NYhRvwH70 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I'd like to start contributing to the base system, but I need clarification on what sort of changes would be welcome. I thought I'd start on simple compiler warnings. The top code in /contrib/top, for example uses K&R-style function definitions and implicit return types that spews -Wimplicit-int and -Wreturn-type warnings. While I'm silencing those, is it appropriate for me to make the file follow style(9)? Once I have a diff, should I just upload it to bugzilla, or is it preferable to put it on phabricator and then link to it from bugzilla? Randy --IU5/I01NYhRvwH70 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXPTzmAAoJEGaweXjzNsmpj3UH/3DF9qmAFPVKJZxe0D+Fmq3B C2nIClbfkFkekVOBuDzVbpMIhzQ5LyFiOEffLMS43sJvBpKvNQ9B3q/c3rXzs3dj GgcuiVr6IxoV9SuxgGQiVIagdOLGXFfsprijvCPkMzVThP+jaT3o5OgH+Uq//AXf zNvK2FYYNgT2Ne8J4XwYUP89UbMEKeN5Ft5iA0+1q3U/165pLo/wQBHUz8bOvPkx 2PzLjjyMG3zzkmqr7tpmHy0gNYEZx1E7e1gZYqy4JnkOEoDgTOetrTlPqidndbZP Jx/GmyctDtYiWLmxtRr5y73nNNdqG21SJVU51N3Iuot7vgXlgKS57JAWlY4XdWc= =ct/z -----END PGP SIGNATURE----- --IU5/I01NYhRvwH70--