Date: Tue, 05 Jun 2018 17:36:54 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 228769] devel/py-testtools: Add missing dependencies (with workaround for devel/py-fixtures et al.) Message-ID: <bug-228769-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228769 Bug ID: 228769 Summary: devel/py-testtools: Add missing dependencies (with workaround for devel/py-fixtures et al.) Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: sunpoet@FreeBSD.org Reporter: freebsd_ports@k-worx.org CC: python@FreeBSD.org, sunpoet@FreeBSD.org Flags: maintainer-feedback?(sunpoet@FreeBSD.org) Assignee: sunpoet@FreeBSD.org Attachment #194031 maintainer-approval?(sunpoet@FreeBSD.org) Flags: CC: sunpoet@FreeBSD.org Created attachment 194031 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D194031&action= =3Dedit py-testtools_RUN_DEPENDS.patch Hello, attached is a patch, that does following modifications: for port devel/py-testtools: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - adds missing dependencies to RUN_DEPENDS (devel/py-pbr, devel/py-fixtures, devel/py-mimeparse, devel/py-unittest2, devel/py-six) - adds LICENSE_FILE - bumps PORTREVISION - changes occurrences of FLAVOR to PY_FLAVOR for port devel/py-fixtures: ~~~~~~~~~~~~~~~~~~~~~~~~~~~ - removes devel/py-testtools from RUN_DEPENDS to avoid circular dependencies (devel/py-testtools + devel/py-fixtures depends on each other, please see further down below for an explanation) - adds a comment for the workaround - changes occurrences of FLAVOR to PY_FLAVOR - bumps PORTREVISION for port devel/py-python-subunit: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - removes redundant entries from RUN_DEPENDS - bumps PORTREVISION - Note: my approval as maintainer for the change is given for port devel/py-mox3: ~~~~~~~~~~~~~~~~~~~~~~~ - changes devel/py-fixtures to devel/py-testtools in RUN_DEPENDS - Note: my approval as maintainer for the change is given Explanation for the workaround: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ As already stated above the ports devel/py-testtools and devel/py-fixtures depends on each other. If those dependencies would be set in the Makefiles = of both ports it would introduce a circular depency which There might be two workarounds to cope with the problem (the attached patch uses option b): a) Create a test for both ports that check if the port sees itself in the RUN_DEPENDS and remove the entry in that case. But there's no known use-cas= e in the ports tree and this approach might be prone to errors. b) Break the possibility of a circular dependency by pruning the dependenci= es on one of the both ports. I did choose devel/py-fixtures because that port = is listed as single instance in only one port at the moment (=3D devel/py-mox3= ). The workaround would be now: - If in the future one port requires devel/py-fixtures without listing devel/py-testtools explicitly then the first one should be replaced with the latter one to resolve the given dependencies (included for devel/py-mox3 in= the supplied patch). What do you think about it? QA: ~~~ - poudriere (11.1-RELEASE amd64 + i386) for each py27 + py36 flavor -> OK - portlint -> OK --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-228769-7788>