From owner-freebsd-hackers  Mon Oct  9 11:59:17 2000
Delivered-To: freebsd-hackers@freebsd.org
Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9D6F837B503; Mon,  9 Oct 2000 11:59:12 -0700 (PDT)
Received: (from brdavis@localhost)
	by odin.ac.hmc.edu (8.11.0/8.11.0) id e99Iwlk03981;
	Mon, 9 Oct 2000 11:58:47 -0700
Date: Mon, 9 Oct 2000 11:58:47 -0700
From: Brooks Davis <brooks@one-eyed-alien.net>
To: Dave Cornejo <dave@dogwood.com>
Cc: Doug Ambrisko <ambrisko@whistle.com>,
	freebsd-hardware@FreeBSD.ORG, freebsd-hackers@FreeBSD.ORG
Subject: Re: WEP keys for an driver
Message-ID: <20001009115847.A2570@Odin.AC.HMC.Edu>
References: <200010091551.IAA30329@whistle.com> <200010091842.e99IgWd05020@white.dogwood.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <200010091842.e99IgWd05020@white.dogwood.com>; from dave@dogwood.com on Mon, Oct 09, 2000 at 11:42:32AM -0700
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Mon, Oct 09, 2000 at 11:42:32AM -0700, Dave Cornejo wrote:
> Some comments on your code:
> - WEP keysare variable length from 5-13 bytes, you should just check for
> >=5 & <=13 (it seems odd, but I have seen networks that use the odd
> sizes).

Since all the windows drivers I've looked at only allow 0, 5, and 13
byte keys, I'd suggest only allowing those values.  That's what
wicontrol does.

> I didn't provide patches to ancontrol as you did, but I find ancontrol
> is getting way too nasty with its switches.  Your patches look fine
> to me except that I'd really like to see a better way to specify
> volatile vs. persistent keys.  

You need to add ancontrol support or the patch is basicaly useless.  I'm
looking forward to some sort of working crypto support for the aironet
cards.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message