Date: Thu, 23 Mar 2006 21:31:43 +0900 From: Norikatsu Shigemura <nork@FreeBSD.org> To: vkashyap@FreeBSD.org Cc: freebsd-current@FreeBSD.org Subject: twa(4) doesn't depend on cam(4) and pci(4). Message-ID: <20060323213143.30d26b6e.nork@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
Hi Vinod. I found a bug that twa(4)'s module doesn't depend on cam(4) and pci(4). Please commit following patch and MFC. I think that there are same bugs in many driver depended on cam(4) like advansys(4), aha(4), ahb(4), amr(4), arcmsr(4), asr(4), .... I confirmed following way: (compare following result) # cd /usr/src/sys/dev # fgrep -l xpt_ */*.c # fgrep MODULE_DEPEND `fgrep -l xpt_ */*.c` So I might miss. Index: tw_osl_freebsd.c =================================================================== RCS file: /home/ncvs/src/sys/dev/twa/tw_osl_freebsd.c,v retrieving revision 1.4 diff -u -r1.4 tw_osl_freebsd.c --- tw_osl_freebsd.c 8 Nov 2005 22:51:43 -0000 1.4 +++ tw_osl_freebsd.c 23 Mar 2006 12:20:29 -0000 @@ -207,6 +207,8 @@ }; DRIVER_MODULE(twa, pci, twa_pci_driver, twa_devclass, 0, 0); +MODULE_DEPEND(sym, cam, 1, 1, 1); +MODULE_DEPEND(sym, pci, 1, 1, 1);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060323213143.30d26b6e.nork>