From owner-freebsd-wireless@freebsd.org Mon Feb 29 02:34:18 2016 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1860AB7CB8 for ; Mon, 29 Feb 2016 02:34:18 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7ABA7158A for ; Mon, 29 Feb 2016 02:34:18 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x231.google.com with SMTP id g203so173057409iof.2 for ; Sun, 28 Feb 2016 18:34:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-transfer-encoding; bh=apCMvNNn07nASooshcitrJ0cspQm6iTH3Cwl5b2Ddac=; b=VDzvMQ617tCT8v0x1xplplXY4rSYRk2iF0ObMQ7rLDnylpYVvw5SGyZ1J6Fpraxrsh SOz+5wGQAZWj5Vx3OS/eWPiBS3iLzVwa9nUxJ2lnarIKqnENTmFcUrSl8ZDrN6yIA77X j0OndPsgWNf9DGUYeiCoryXnvgTXO4lDdBFaekSvUH4TUG353fRhIs34ajvbe0VB0IVy fI7EydO6ZRF+M8D9u3k4hdr+ZHrxQHEqn//rqJFpRikLpUreob0KFVnwq3BfZYpOQ58r dFD/aLakrg2ZHczn/VJ48msJZhD9McSug9GW3O7j+ETXn5t5YKYcU2ljDwxX38CWM9L6 y8eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=apCMvNNn07nASooshcitrJ0cspQm6iTH3Cwl5b2Ddac=; b=mbYPBpCRRHQ9FwgKx7eggVDNPkJZ6vJgw8vQKV+wf3xNncqxK/t2eAJVaAKiFARrdc LicuC6/8XHhVYmW8b1hmSwi6XxHcEIXXNMiZQY42ykzxdohzSToKoS/32YqItmr25wX6 qsK+wYl69faj4GP5QdZBbAZHY3u9KCXAGA6FJjONi0tu9t5mxJHqXGxr9ROOoYZFMuvC zyv7ELg/VU+OLVeu2pO/WYEmd/cq8VgrIisU15eZvPcinZGpTYKDAT7XoLG0L2PCtE/y zH+X0XOf0jTe8k/cw/yjQeELTOwqF/XGUAUpGFQvQSzFnY8nwHVEYfGjxepcvhb/QDEj jwlg== X-Gm-Message-State: AG10YORevBC8hy3b4XGhegToxP0BWH64C7SRuZ/rxpUgcAmI9HNkTExSbmDuwHcFJDueZqBSjdcox96ER1Jg/Q== MIME-Version: 1.0 X-Received: by 10.107.11.231 with SMTP id 100mr16540587iol.165.1456713257935; Sun, 28 Feb 2016 18:34:17 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.36.14.19 with HTTP; Sun, 28 Feb 2016 18:34:17 -0800 (PST) In-Reply-To: References: Date: Sun, 28 Feb 2016 18:34:17 -0800 X-Google-Sender-Auth: R9o9Ll4P194vViwpdeDKC9-8oZQ Message-ID: Subject: Re: software scan fix - please test (Was: why we can't use the net80211 taskqueue for everything) From: Adrian Chadd To: Andriy Voskoboinyk Cc: "freebsd-wireless@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Feb 2016 02:34:18 -0000 ok, Tested this out on iwn and urtwn, with some scans during traffic. So far so good. I'll test with ath tonight too just to see. Thanks! -adrian On 28 February 2016 at 11:15, Andriy Voskoboinyk wrote: > Sat, 20 Feb 2016 12:06:17 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Andriy Voskoboinyk > : > > >>> hi, >>> >>> andriy has a few reviews out that tidy up some things, which I'd reply >>> to, but .. reviews is offline. So, here's the 30 second version: >>> >>> * the net80211 taskqueue runs the software scan engine, and the >>> software scan engine currently sleeps whilst it's running. >>> >>> This means that if you put newstate, deferred transmit, etc into the >>> net80211 taskqueue, then it just won't run during scan. >>> >>> The net80211 software scan thing should be modified to not sleep >>> whilst it's waiting for scan results and instead just kick off another >>> timer event to finish that part of the loop. Then yes, we can just >>> migrate * to the net80211 task queue and use it for all serialisation >>> of a wifi driver. >>> >>> (And yes, I'd like to see that done ASAP..) >>> >>> Thanks, >>> >>> >>> -adrian >> >> >> Hi, >> >> I have replaced sleeping on conditional variable inside scan task >> with scan_curchan task rescheduling (so this problem should be fixed now= ). >> >> For everyone, who wishes to test: apply the attached patch >> (merged from D5133, D5137, D5139, D5140, D5142, D5143, D5145, D5147, D51= 48 >> and D5152) >> and rebuild + install the kernel. Scan should work as before. >> >> Thanks! > > > Newer patch includes fix for > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D197498#c7 > (D5482) - so, scanning for adhoc/hostap mode should work now.