Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Jul 2022 12:46:01 +0000
From:      bugzilla-noreply@freebsd.org
To:        xfce@FreeBSD.org
Subject:   [Bug 265378] x11/xfce4-goodies can depend on sysutils/xfce4-battery-plugin when battery-plugin is unbuildable
Message-ID:  <bug-265378-28711-ydvb1T36pL@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-265378-28711@https.bugs.freebsd.org/bugzilla/>
References:  <bug-265378-28711@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265378

--- Comment #4 from Guido Falsi <madpilot@FreeBSD.org> ---
Created attachment 235425
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D235425&action=
=3Dedit
patch v1

I've attached a patch I've still not tested.

The patch removed BATTERY from the global defaults and puts it in
OPTIONS_DEFAULT_amd64 and OPTIONS_DEFAULT_i386, so it's not the default exc=
ept
where supported.

I've also added some OPTIONS_EXCLUDE_${ARCH}. To keep the list short I deci=
ded
to only add the ones relating to the architecture supported by HEAD (upcomi=
ng
14.x), as a compromise.

aarch64 was very important to add since it's becoming tier 1.

BTW I have no way of testing the xfce4-battery-plugin plugin on aarch64, bu=
t if
you want to give it a spin, just comment the ONLY_FOR_ARCHS (or add aarch64)
there and see how it behaves. If it happens to work on aarch64 I can enable=
 it.

BTW while here I am enabling BSDCPUFREQ by default again since it should wo=
rk
now (I'm going to test this before committing anyway).

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-265378-28711-ydvb1T36pL>