From owner-cvs-src@FreeBSD.ORG Wed Mar 9 20:33:36 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A8DFB16A4CE; Wed, 9 Mar 2005 20:33:36 +0000 (GMT) Received: from pd2mo3so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 644F343D41; Wed, 9 Mar 2005 20:33:36 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd3mr7so.prod.shaw.ca (pd3mr7so-qfe3.prod.shaw.ca [10.0.141.23])2004)) with ESMTP id <0ID300473QFP7O80@l-daemon>; Wed, 09 Mar 2005 13:33:25 -0700 (MST) Received: from pn2ml5so.prod.shaw.ca ([10.0.121.149]) by pd3mr7so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0ID3009XZQFPF7F0@pd3mr7so.prod.shaw.ca>; Wed, 09 Mar 2005 13:33:25 -0700 (MST) Received: from [192.168.0.60] (S0106006067227a4a.vc.shawcable.net [24.87.209.6]) by l-daemon (iPlanet Messaging Server 5.2 HotFix 1.18 (built Jul 28 2003)) with ESMTP id <0ID3008D3QFO7X@l-daemon>; Wed, 09 Mar 2005 13:33:25 -0700 (MST) Date: Wed, 09 Mar 2005 12:33:24 -0800 From: Colin Percival In-reply-to: <422F5B36.5090400@criticalmagic.com> To: Richard Coleman Message-id: <422F5D94.4030702@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Accept-Language: en-us, en X-Enigmail-Version: 0.90.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime References: <200503091923.j29JN4Ti063868@repoman.freebsd.org> <422F50A6.907@criticalmagic.com> <422F55C6.3000207@freebsd.org> <422F5B36.5090400@criticalmagic.com> User-Agent: Mozilla Thunderbird 1.0 (X11/20050302) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libmd Makefile sha256.3 sha256.h sha256c.c shadriver.c src/sbin/md5 Makefile md5.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2005 20:33:37 -0000 Richard Coleman wrote: > Colin Percival wrote: >> As far as I could tell, we didn't have sha256 in the tree until I added >> it. As for md5 and sha1, it's useful to have a minimalist libmd for >> applications which don't require the bloated monst^W^W^W OpenSSL, and >> these are small enough that a bit of duplication really doesn't matter. > > There are versions of sha256, sha384, and sha512 in sys/crypto/sha2. *sigh* Oh well, I think my version is cleaner anyway... :-) > Just a random thought. But I'm glad to see sha256 added to libmd > anyways. It may be useful to add sha384 and sha512 as well. I considered that, but decided that since those hashes are designed for 64 bit processors, they would be more trouble than they're worth. My personal feeling is that sha(384|512) are overkill on the side of hash length and probably underkill on the side of design (considering that they have the same basic design which has been repeatedly shown to be vulnerable to the Chinese attack) anyway -- we really need an AES-like process for selecting a new hash standard. Colin Percival