From owner-freebsd-current Thu Aug 26 23:58:17 1999 Delivered-To: freebsd-current@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id 94F6E14EE9 for ; Thu, 26 Aug 1999 23:58:11 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.2) with ESMTP id IAA03841; Fri, 27 Aug 1999 08:55:04 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Greg Lehey Cc: Matthew Dillon , Christopher Masto , "John W. DeBoskey" , julian@whistle.com, freebsd-current@FreeBSD.ORG Subject: Re: -current kernel problems (spec_getpages & vm_fault) In-reply-to: Your message of "Fri, 27 Aug 1999 16:09:50 +0930." <19990827160950.X483@freebie.lemis.com> Date: Fri, 27 Aug 1999 08:55:04 +0200 Message-ID: <3839.935736904@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Greg, 4K is probably too conservative, it only applies if you have a swap-backed vn device at the bottom, which would be a truly weird thing to do with vinum. Don't spend too much time on tracking the sector size yet. I think the si_bsize stuff needs some thinking before we do more with it. Poul-Henning In message <19990827160950.X483@freebie.lemis.com>, Greg Lehey writes: >On Thursday, 26 August 1999 at 16:25:14 -0700, Matthew Dillon wrote: >>>>> int devminor; /* minor number */ >>>>> >>>>> devminor = minor(dev); >>>>> + dev->si_bsize_phys = DEV_BSIZE; >>>>> + dev->si_bsize_best = BLKDEV_IOSIZE; >>>>> + dev->si_bsize_max = MAXBSIZE; >>>> >>>> Bingo! Thank you. >>> >>> Cool, I expect grog will commit it soon. > >So did I until I read this message. > >> The patch for ccd is not quite right. Here is the patch from my >> big fat patch at http://www.backplane.com/FreeBSD4/ >> >> The problem is that you cannot simply set the physical sector >> size to DEV_BSIZE if the underlying device has a larger sector >> size. If you do, specfs's blocksize alignment (another fix in >> my big fat patch) will be incorrect and result in an I/O error >> on the physical media. >> >> For example, swap-backed VN devices have a sector size of one page, >> i.e. 4K. > >Vinum currently doesn't track the sector size of the drives. I'll >have to put some code in there to DTRT. In the meantime, I'll set >si_bsize_best to 4K in the hope that this will be OK. Are there any >larger block sizes in current use? > >Greg >-- >See complete headers for address, home page and phone numbers >finger grog@lemis.com for PGP public key > -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message