From owner-p4-projects@FreeBSD.ORG  Tue Jul 28 13:00:44 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id AFEAC10656B4; Tue, 28 Jul 2009 13:00:43 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 63C6B1065679;
	Tue, 28 Jul 2009 13:00:43 +0000 (UTC)
	(envelope-from rnoland@FreeBSD.org)
Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195])
	by mx1.freebsd.org (Postfix) with ESMTP id 282D08FC14;
	Tue, 28 Jul 2009 13:00:42 +0000 (UTC)
	(envelope-from rnoland@FreeBSD.org)
Received: from [192.168.1.4] (adsl-154-218-245.ard.bellsouth.net
	[72.154.218.245]) (authenticated bits=0)
	by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id n6SCZi0S035956
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 28 Jul 2009 08:35:45 -0400 (EDT)
	(envelope-from rnoland@FreeBSD.org)
From: Robert Noland <rnoland@FreeBSD.org>
To: Hans Petter Selasky <hselasky@FreeBSD.org>
In-Reply-To: <200907281029.n6SATPUh047306@repoman.freebsd.org>
References: <200907281029.n6SATPUh047306@repoman.freebsd.org>
Content-Type: text/plain
Organization: FreeBSD
Date: Tue, 28 Jul 2009 07:35:39 -0500
Message-Id: <1248784539.73923.4.camel@balrog.2hip.net>
Mime-Version: 1.0
X-Mailer: Evolution 2.26.3 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_PBL,
	RCVD_IN_SORBS_DUL, RDNS_DYNAMIC, SPF_SOFTFAIL autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 166673 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2009 13:00:44 -0000

On Tue, 2009-07-28 at 10:29 +0000, Hans Petter Selasky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=166673
> 
> Change 166673 by hselasky@hselasky_laptop001 on 2009/07/28 10:28:46
> 
> 	
> 	USB controller:
> 	 - allow disabling "root_mount_hold()" by setting a sysctl

Shouldn't this be a tuneable?  Possibly mirrored by a read only sysctl?

robert.

> Affected files ...
> 
> .. //depot/projects/usb/src/sys/dev/usb/controller/usb_controller.c#22 edit
> 
> Differences ...
> 
> ==== //depot/projects/usb/src/sys/dev/usb/controller/usb_controller.c#22 (text+ko) ====
> 
> @@ -79,6 +79,10 @@
>      "Debug level");
>  #endif
>  
> +static int usb_no_boot_wait = 0;
> +SYSCTL_INT(_hw_usb, OID_AUTO, no_boot_wait, CTLFLAG_RW, &usb_no_boot_wait, 0,
> +    "No device enumerate waiting at boot.");
> +
>  static uint8_t usb_post_init_called = 0;
>  
>  static devclass_t usb_devclass;
> @@ -132,8 +136,10 @@
>  		return (ENXIO);
>  	}
>  
> -	/* delay vfs_mountroot until the bus is explored */
> -	bus->bus_roothold = root_mount_hold(device_get_nameunit(dev));
> +	if (usb_no_boot_wait == 0) {
> +		/* delay vfs_mountroot until the bus is explored */
> +		bus->bus_roothold = root_mount_hold(device_get_nameunit(dev));
> +	}
>  
>  	if (usb_post_init_called) {
>  		mtx_lock(&Giant);
-- 
Robert Noland <rnoland@FreeBSD.org>
FreeBSD