From owner-freebsd-bugs  Sun Jan  6 17:50:14 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 38E6337B41B
	for <freebsd-bugs@hub.freebsd.org>; Sun,  6 Jan 2002 17:50:01 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g071o1478847;
	Sun, 6 Jan 2002 17:50:01 -0800 (PST)
	(envelope-from gnats)
Received: from shumai.marcuscom.com (rdu57-28-046.nc.rr.com [66.57.28.46])
	by hub.freebsd.org (Postfix) with ESMTP id D019137B402
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  6 Jan 2002 17:46:45 -0800 (PST)
Received: (from marcus@localhost)
	by shumai.marcuscom.com (8.11.6/8.11.6) id g071kkV07013;
	Sun, 6 Jan 2002 20:46:46 -0500 (EST)
	(envelope-from marcus)
Message-Id: <200201070146.g071kkV07013@shumai.marcuscom.com>
Date: Sun, 6 Jan 2002 20:46:46 -0500 (EST)
From: Joe Marcus Clarke <marcus@marcuscom.com>
Reply-To: Joe Marcus Clarke <marcus@marcuscom.com>
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.113
Subject: kern/33625: [PATCH] Add KMODDEPS to smbfs to load libiconv and libmchain
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         33625
>Category:       kern
>Synopsis:       [PATCH] Add KMODDEPS to smbfs to load libiconv and libmchain
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 06 17:50:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Joe Marcus Clarke
>Release:        FreeBSD 4.5-PRERELEASE i386
>Organization:
MarcusCom, Inc.
>Environment:
System: FreeBSD shumai.marcuscom.com 4.5-PRERELEASE FreeBSD 4.5-PRERELEASE #0: Sun Jan 6 01:07:48 EST 2002 marcus@shumai.marcuscom.com:/usr/obj/usr/src/sys/SHUMAI i386


	
>Description:
	When you kldload smbfs without kldload'ing libconv or libmchain, you get
the error:

Jan  6 18:22:02 shumai /kernel: link_elf: symbol iconv_open undefined

Or something having to do with a missing libmchain symbol.  Users that don't
know that libiconv or libmchain are needed, can get confused.  Instead, 
make smbfs depend on libiconv and libmchain.
>How-To-Repeat:
	# kldload smbfs

Without first loading libiconv or libmchain.
>Fix:
This patch is only really needed on -stable, since KMODDEPS isn't required
for -current(?)

--- sys/modules/smbfs/Makefile.orig	Sun Jan  6 20:41:48 2002
+++ sys/modules/smbfs/Makefile	Sun Jan  6 20:38:55 2002
@@ -7,6 +7,7 @@
 	${.CURDIR}/../../fs/smbfs
 
 KMOD=	smbfs
+KMODDEPS=	libiconv libmchain
 
 SRCS=	vnode_if.h \
 	opt_inet.h opt_ipx.h \

>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message