From nobody Tue Feb 4 22:20:31 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ynd9D0X1Sz5mZQj; Tue, 04 Feb 2025 22:20:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ynd9C6wwpz3x5T; Tue, 04 Feb 2025 22:20:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738707632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9aK+/PM9qDiUtX7/PwBoKFngIQSU1B0RmtjHowU82mo=; b=OvQax3oNuVn3NJ0aJTFKCA5JyZJiGjN3pYGYcSkiWGrwRTcQDAmqjFtPPpMVsSVBhIS0rm SZiniVD/3hzcV5sNXf7nu5VsgVFcc2FX0/fqbLhHwUKAcpvz+7X0eIMGt5hGnjnqqgDWon gaY8mmn23d5+AaFmBNCpQb8/RHhKszVvyDqQdceLyVh7kS//vXPdEokRV+z2jOok8Urmjx XfO0DR2d7CmjYHKFSpHmj+/l1XC3/tcHp20WQlkQgWQ3dwd2eSqm+HM2OT0cUJXvs60XZn sXjLPlzJ4yeVni2xIEpMKclq80ORZ+pcL2QAhvWmB0ttTqj3yW7IrY9x+JQQ5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738707632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9aK+/PM9qDiUtX7/PwBoKFngIQSU1B0RmtjHowU82mo=; b=yV1r0Ejw2YBDtAw64BaSQr5NP3ivUGHCaFlO89aF8QOAp12V/nC7z9biEu4xCOkWHy/TIR GWKDkz8X5Cm2OUbzBtR+Q3H7bvFOT1mjtxnGrElcfb3TNBfhs4RwOdNFF1d+9Jd+YiARiJ WOeYBSXIL9lUn8fTFGKgj4lJiys78pGkZjk+dZloV+WgL9n8WULkCH7En1ZXa0J0aRHEUx mxdjE3S29O1w3qWq24yvqIT0Q3mFCMPqlYsK/yAFlbYe4X0lyUsqtjIt/1WXYktCYAElS3 Gd8Hq+TJbcc/oRK1PeUJYrV3RSDB/Yq9CowQqrUXwVtwahEzkTNpSzRwbNLGlA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738707632; a=rsa-sha256; cv=none; b=ev/L4NqEo/krW9iZ2z5k4RbSTClfleeNOQpX2vbfY7+7jmeo1DhuwqgR7vAuxpXEOSFw/G eQQ1YPWrKV1GHtyKZ26IV4B/+6W9k9925aJ/zi9G3go3yUN/qWj5BHRoGuIQAtMtTdUKnL e85I7FtqE8bko+XOpWi832FoeFE23hlj8w5MD8vhKj5wh6BEqYC0RmagOIUqneAfFMv7ir Y3xzV5MDgJgdOf+K7zA/lt155ZhaIF6mNaBNS8qi/P6MBjanmz+Mg6RkUbI90ZKNK3hNG4 4NUEkN/pbPUYyB3LY6Sne3GcOgsAd7fc+4i8Bd+GgNl/m7O1IHUk9FmZDevFlA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ynd9C6F8hz8jF; Tue, 04 Feb 2025 22:20:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 514MKVsu063991; Tue, 4 Feb 2025 22:20:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 514MKV6Y063988; Tue, 4 Feb 2025 22:20:31 GMT (envelope-from git) Date: Tue, 4 Feb 2025 22:20:31 GMT Message-Id: <202502042220.514MKV6Y063988@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 1a0cb938f7b4 - main - unlink, rmdir: call notify_upper from VOP pre method instead of syscall List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1a0cb938f7b461edc40316cb44a80438df674174 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=1a0cb938f7b461edc40316cb44a80438df674174 commit 1a0cb938f7b461edc40316cb44a80438df674174 Author: Konstantin Belousov AuthorDate: 2025-02-04 00:23:05 +0000 Commit: Konstantin Belousov CommitDate: 2025-02-04 22:19:50 +0000 unlink, rmdir: call notify_upper from VOP pre method instead of syscall Suppose that there are two or more nullfs mounts over some fs, and suppose the we unlink a file on one of the nullfs mount. This way notify_upper get called from the lower vnode as well, allowing the other nullfs mounts to note that and drop their caches for the unlinked vnode. PR: 254210 Reviewed by: olce Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D48825 --- sys/kern/vfs_subr.c | 2 ++ sys/kern/vfs_syscalls.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index ef51fdba8e7c..9e9b56064ecf 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -6224,6 +6224,7 @@ vop_remove_pre(void *ap) a = ap; dvp = a->a_dvp; vp = a->a_vp; + vfs_notify_upper(vp, VFS_NOTIFY_UPPER_UNLINK); vn_seqc_write_begin(dvp); vn_seqc_write_begin(vp); } @@ -6292,6 +6293,7 @@ vop_rmdir_pre(void *ap) a = ap; dvp = a->a_dvp; vp = a->a_vp; + vfs_notify_upper(vp, VFS_NOTIFY_UPPER_UNLINK); vn_seqc_write_begin(dvp); vn_seqc_write_begin(vp); } diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index bbd67c2b0326..41609d7c5351 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -2034,7 +2034,6 @@ restart: if (error != 0) goto out; #endif - vfs_notify_upper(vp, VFS_NOTIFY_UPPER_UNLINK); error = VOP_REMOVE(nd.ni_dvp, vp, &nd.ni_cnd); #ifdef MAC out: @@ -4002,7 +4001,6 @@ restart: goto fdout; goto restart; } - vfs_notify_upper(vp, VFS_NOTIFY_UPPER_UNLINK); error = VOP_RMDIR(nd.ni_dvp, nd.ni_vp, &nd.ni_cnd); vn_finished_write(mp); out: