From owner-cvs-src@FreeBSD.ORG  Thu Dec  1 18:05:19 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.ORG
Delivered-To: cvs-src@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 33E0316A41F;
	Thu,  1 Dec 2005 18:05:19 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8614F43D5E;
	Thu,  1 Dec 2005 18:05:18 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1] (may be forged))
	by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id jB1I59UT060347;
	Thu, 1 Dec 2005 11:05:09 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Thu, 01 Dec 2005 11:05:44 -0700 (MST)
Message-Id: <20051201.110544.07119736.imp@bsdimp.com>
To: ru@FreeBSD.ORG
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20051201172757.GG20961@ip.net.ua>
References: <200512011708.jB1H8u3Y065515@repoman.freebsd.org>
	<20051201172757.GG20961@ip.net.ua>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Thu, 01 Dec 2005 11:05:09 -0700 (MST)
Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src Makefile.inc1
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Dec 2005 18:05:19 -0000

In message: <20051201172757.GG20961@ip.net.ua>
            Ruslan Ermilov <ru@FreeBSD.ORG> writes:
: On Thu, Dec 01, 2005 at 05:08:56PM +0000, Warner Losh wrote:
: > imp         2005-12-01 17:08:56 UTC
: > 
: >   FreeBSD src repository
: > 
: >   Modified files:
: >     .                    Makefile.inc1 
: >   Log:
: >   In make buildenv, spell sh as ${SHELL}.  In this case, we don't want
: >   to hard code /bin/sh since we're forking it for the user to type
: >   commands into.  As such, ${SHELL} is the preferred thing users type
: >   commands into.
: >   
: >   Revision  Changes    Path
: >   1.524     +1 -1      src/Makefile.inc1
: > 
: Please consider backing it out.  In this case, we want to hard code it
: to "sh" since the stock ~root/.cshrc always resets $PATH, which breaks
: "make buildenv" for root (which most of us use).  Testcase: "which cc"
: from under "make buildenv" shell.

This is an insufficient reason to hard code it to sh.  My .cshrc files
are written properly and make buildenv works.  We should consider
fixing ~root/.cshrc instead to do the right thing with its path.  What
would be wrong with

Index: dot.cshrc
===================================================================
RCS file: /home/ncvs/src/etc/root/dot.cshrc,v
retrieving revision 1.29
diff -u -r1.29 dot.cshrc
--- dot.cshrc	1 Apr 2004 19:28:00 -0000	1.29
+++ dot.cshrc	1 Dec 2005 18:04:01 -0000
@@ -14,7 +14,7 @@
 # A righteous umask
 umask 22
 
-set path = (/sbin /bin /usr/sbin /usr/bin /usr/games /usr/local/sbin /usr/local/bin /usr/X11R6/bin $HOME/bin)
+set path = ($path /sbin /bin /usr/sbin /usr/bin /usr/games /usr/local/sbin /usr/local/bin /usr/X11R6/bin $HOME/bin)
 
 setenv	EDITOR	vi
 setenv	PAGER	more

I hate enteracting with a sh prompt...

Warner