From owner-dev-commits-src-main@freebsd.org Wed Feb 10 19:38:10 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B8A7528B92 for ; Wed, 10 Feb 2021 19:38:10 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DbVRP4fMJz3Drh for ; Wed, 10 Feb 2021 19:38:09 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-lf1-f52.google.com with SMTP id d3so4579800lfg.10 for ; Wed, 10 Feb 2021 11:38:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NJsci89OA2fPyZGPJmBk9h98HhBAcJbE6RJBJ/M+owk=; b=FzEcngTSFPwvvBrmIaFkkcdwujh8Ksq4i32e53mHUi32KzWINpPZO5QEphaOpFm5sz 1TBdGLnWzFY4Yj4HW2lrbmQsf+Fyq6Eqda6YlezUae08ALf0tnGUeltB45Bbg9TBNkeG LPGhhOfm8lBiUcUEqxfdYMQYxUOqMhhxUCVv3FblzzfLPGZ6oAiTU7Dg7uioCgnwq81G VIY7b4bksYW2sGVZZ/SG2bt5GNANGCHZUz7a6nocWjLXwTGxux4/vYue+CYEKW3wXETT dw31usbwCQwXGUizTWETevg0AMcmm+mxKaaS3Lp88tSl9sNcEjWODIjEMvVoDCIwWvXf 5GlQ== X-Gm-Message-State: AOAM532869ryrOubQYbPXl0Hty5dTRoRoBhZ1VVmmmmcMv576/MHajIs PWFesT5QwGE1/E6e3Wtbhz9r8SdypNFazA== X-Google-Smtp-Source: ABdhPJxc64mr8NsFjaWTpoyN/1yBMkNfXkZfH540/bwI6jOGMUH7ZLz3LF8aJieTDmrFQAYWSAEJTg== X-Received: by 2002:a19:2341:: with SMTP id j62mr2399736lfj.413.1612985887705; Wed, 10 Feb 2021 11:38:07 -0800 (PST) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com. [209.85.167.50]) by smtp.gmail.com with ESMTPSA id f2sm436558lfc.240.2021.02.10.11.38.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Feb 2021 11:38:07 -0800 (PST) Received: by mail-lf1-f50.google.com with SMTP id d3so4579690lfg.10 for ; Wed, 10 Feb 2021 11:38:07 -0800 (PST) X-Received: by 2002:a05:6512:2014:: with SMTP id a20mr2351086lfb.437.1612985886673; Wed, 10 Feb 2021 11:38:06 -0800 (PST) MIME-Version: 1.0 References: <202102042333.114NXowE086993@gitrepo.freebsd.org> In-Reply-To: From: Eric Joyner Date: Wed, 10 Feb 2021 11:37:55 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 7d4dceec1030 - main - ixl(4): Fix VLAN HW filtering To: Kyle Evans Cc: Krzysztof Galazka , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4DbVRP4fMJz3Drh X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.167.52:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[209.85.167.52:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.52:from]; R_DKIM_NA(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.52:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-main] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2021 19:38:10 -0000 Yeah, Internally we have the ixl and iavf drivers split up so that they no longer share source and have independent code bases, but that change hasn't made it upstream yet. Doing that would fix the dependency issue, so I'll see about doing that ASAP, possibly for 13.0. I recently came back from a long vacation, so I have to catch up on all of these things. :( - Eric On Sat, Feb 6, 2021 at 10:32 AM Kyle Evans wrote: > On Sat, Feb 6, 2021 at 12:30 PM Kyle Evans wrote: > > > > On Thu, Feb 4, 2021 at 5:34 PM Eric Joyner wrote: > > > > > > The branch main has been updated by erj: > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=7d4dceec103039e2b2fa90793ceeb71a8d6684aa > > > > > > commit 7d4dceec103039e2b2fa90793ceeb71a8d6684aa > > > Author: Krzysztof Galazka > > > AuthorDate: 2021-02-03 23:22:55 +0000 > > > Commit: Eric Joyner > > > CommitDate: 2021-02-04 23:33:42 +0000 > > > > > > ixl(4): Fix VLAN HW filtering > > > > > > X700 family of controllers has limited number of available VLAN > > > HW filters. Driver did not handle properly a case when user > > > assigned more VLANs to the interface which had all filters > > > already in use. Fix that by disabling HW filtering when > > > it is impossible to create filters for all requested VLANs. > > > Keep track of registered VLANs using bitstring to be able > > > to re-enable HW filtering when number of requested VLANs > > > drops below the limit. > > > > > > Also switch all allocations to use M_IXL malloc type > > > to ease detecting memory leaks in the driver. > > > > > > > Hi, > > > > This adds a dependency on `device ixl` for `device iavf` since M_IXL > > is defined in ixl_pf_main.c, but I think that particular part should > > be partially reverted anyways. There's an M_IAVF already that's more > > appropriate for i40e_osdep.c -- proposed patch here: > > > https://people.freebsd.org/~kevans/0001-ixl-switch-i40e_osdep.c-allocations-to-M_IAVF.patch > > > > Ah crud, nope. I missed that i40e_osdep is pulled in for ixl as well. :-( >