From owner-svn-src-all@FreeBSD.ORG Mon May 11 19:18:50 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E9511C6C; Mon, 11 May 2015 19:18:50 +0000 (UTC) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) by mx1.freebsd.org (Postfix) with ESMTP id C65BF1DB2; Mon, 11 May 2015 19:18:50 +0000 (UTC) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 436AA5A9F25; Mon, 11 May 2015 19:18:50 +0000 (UTC) Date: Mon, 11 May 2015 19:18:50 +0000 From: Brooks Davis To: John Baldwin Cc: Xin LI , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r282672 - head/etc/rc.d Message-ID: <20150511191850.GC68045@spindle.one-eyed-alien.net> References: <201505082336.t48NaWRS080408@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2015 19:18:51 -0000 On Sun, May 10, 2015 at 03:45:48PM -0400, John Baldwin wrote: > > > On May 8, 2015, at 19:36, Xin LI wrote: > > > > Author: delphij > > Date: Fri May 8 23:36:31 2015 > > New Revision: 282672 > > URL: https://svnweb.freebsd.org/changeset/base/282672 > > > > Log: > > Always convert uuid to lower case. > > > > MFC after: 2 weeks > > > > Modified: > > head/etc/rc.d/hostid > > > > Modified: head/etc/rc.d/hostid > > ============================================================================== > > --- head/etc/rc.d/hostid Fri May 8 23:29:42 2015 (r282671) > > +++ head/etc/rc.d/hostid Fri May 8 23:36:31 2015 (r282672) > > @@ -58,7 +58,7 @@ hostid_set() > > > > valid_hostid() > > { > > - uuid=$1 > > + uuid=$(echo $1 | tr '[:upper:]' '[:lower:]') > > tr is in /usr/bin so this breaks systems with a separate /usr. Perhaps you could use dd with conv=lcase instead? Alterntively, a shell function "ltr" exists in rc.subr for this purpose. -- Brooks