Date: Sun, 5 Jun 2022 16:18:10 -0400 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: freebsd-arch@freebsd.org Subject: Re: bsdinstall TUI utility Message-ID: <2d9a9f33-857e-5f42-e323-f8459d1a8197@freebsd.org> In-Reply-To: <7a4a099f-213b-b055-4c67-c4b89f7744fe@gmail.com> References: <7a4a099f-213b-b055-4c67-c4b89f7744fe@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
A few days late to this, but I added Xdialog support kind of on a lark in the original version of the utility. I don't think anyone has ever used it or cared about, and I think it can be nuked without issue. -nathan On 5/28/22 17:59, Alfonso S. Siciliano wrote: > Hello, > > > So far I replaced and adapted `dialog` with `bsddialog` in > bsdinstall/scripts. > <https://wiki.freebsd.org/RoadmapFromDialogToBSDDialog>; > > > Currently, I am addressing the last 4 scripts: auto, bootconfig, keymap, > and wlanconfig. These scripts use also the $DIALOG variable and some > "if" to handle Xdialog(1). > For example 'auto' uses $DIALOG, $USE_XDIALOG, and `dialog`. > > * $DIALOG: I seem bsdinstall(8) uses only dialog(1) as TUI utility. > * I seem bsdconfig(8) does not "call" these 4 scripts, so, probably, > Xdialog(1) is not used in this context (that is `bsdconfig -X`). > > > Is there any objection to delete $DIALOG/LGPL-dialog/Xdialog to > provide only the support for bsddialog(1) in bsdinstall(8)? > > I would prefer this solution because I can avoid: to handle some > dialog/Xdialog/bsddialog command line difference and to hook some > bsdconfig function built on dialog(1) incompatible with bsddialog(1) > (for example autosizing, implemented in bsddialog(3) already). > > > Please note these considerations are only for bsdinstall, bsdconfig is > unchanged. > > > Best regards, > Alfonso >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2d9a9f33-857e-5f42-e323-f8459d1a8197>