From owner-cvs-all Tue Mar 5 10:26:30 2002 Delivered-To: cvs-all@freebsd.org Received: from beppo.feral.com (beppo.feral.com [192.67.166.79]) by hub.freebsd.org (Postfix) with ESMTP id 1302837B400; Tue, 5 Mar 2002 10:26:18 -0800 (PST) Received: from mailhost.feral.com (mjacob@mailhost.feral.com [192.67.166.1]) by beppo.feral.com (8.11.3/8.11.3) with ESMTP id g25IQHf36252; Tue, 5 Mar 2002 10:26:17 -0800 (PST) (envelope-from mjacob@feral.com) Date: Tue, 5 Mar 2002 10:26:17 -0800 (PST) From: Matthew Jacob X-Sender: mjacob@beppo Reply-To: mjacob@feral.com To: John Baldwin Cc: Jeff Roberson , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: RE: cvs commit: src/sys/sys smp.h src/sys/kern subr_smp.c src/sy In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG We went thru this discussion a while back. There's no reason why we can't make CPUid virtual, right? Except that it does cost in terms of performance if you then have to fetch the hardware id. On Tue, 5 Mar 2002, John Baldwin wrote: > > On 05-Mar-02 Jeff Roberson wrote: > > jeff 2002/03/05 02:01:46 PST > > > > Modified files: > > sys/sys smp.h > > sys/kern subr_smp.c > > sys/i386/i386 mp_machdep.c > > sys/alpha/alpha mp_machdep.c > > Log: > > Add a new variable mp_maxid. This is used so that per cpu datastructures > > may > > be allocated as arrays indexed by the cpu id. Previously the only reliable > > way to know the max cpu id was through MAXCPU. mp_ncpus isn't useful here > > because cpu ids may be sparsely mapped, although x86 and alpha do not do > > this. > > Actually, alpha ID's can be sparse as they are just phyiscal ID's which are > tied to the slots the CPU's are in. > > > Also, call cpu_mp_probe much earlier so the max cpu id is known before the > > VM > > starts up. This is intended to help support per cpu queues for the new > > allocator, but may be useful elsewhere. > > > > Reviewed by: jake > > Approved by: jake > > > > Revision Changes Path > > 1.34 +2 -0 src/sys/alpha/alpha/mp_machdep.c > > 1.179 +4 -1 src/sys/i386/i386/mp_machdep.c > > 1.163 +14 -2 src/sys/kern/subr_smp.c > > 1.70 +1 -0 src/sys/sys/smp.h > > -- > > John Baldwin <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message