From owner-freebsd-stable@FreeBSD.ORG Sat Jun 22 06:21:46 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 784F8364 for ; Sat, 22 Jun 2013 06:21:46 +0000 (UTC) (envelope-from swhetzel@gmail.com) Received: from mail-ie0-x22d.google.com (mail-ie0-x22d.google.com [IPv6:2607:f8b0:4001:c03::22d]) by mx1.freebsd.org (Postfix) with ESMTP id 4CC7A1E71 for ; Sat, 22 Jun 2013 06:21:46 +0000 (UTC) Received: by mail-ie0-f173.google.com with SMTP id k13so21191386iea.32 for ; Fri, 21 Jun 2013 23:21:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3GZ0GD4wevrqTswNET/RuCpg1/uFEV3/1Z0L4sYGpoQ=; b=mSHH/ghUxxzeHBm/Dw14IvWQDvqqkBSX48eTAl9s+PjPx+iIVnOxtqQxzv0zh+/FjV cdCvq1l0z+nGcDN72u6f8y3naNcpPDmu3h8T59j94+N2SsN4VlVBdw3lAEc/gEg1g0LS o/lQwk/0U+Phoh9fvWFsyNCvKCSEN6wr0OKiKaDjFam07KTiGgFIa+sO+KK5TVePxVes xJvKkCAqTt6EcwVBpCSdyD6O+OgveeP/9ov3UqeyITAvJNbW2Nk3i53cTuO/Rwu+eWhZ TUkfueKzXX9sX1UO5UmttLN1V4dLoaQzAOosYC9p/7oWoXc+2iBS6l1AUx1fx6uvDF9k Tltg== MIME-Version: 1.0 X-Received: by 10.50.67.43 with SMTP id k11mr798609igt.26.1371882105922; Fri, 21 Jun 2013 23:21:45 -0700 (PDT) Received: by 10.50.221.179 with HTTP; Fri, 21 Jun 2013 23:21:45 -0700 (PDT) In-Reply-To: <51C2CB42.4030301@dilkie.com> References: <51C22E11.3020008@quip.cz> <51C23ED9.7070107@quip.cz> <51C2499B.2060209@quip.cz> <51C2CB42.4030301@dilkie.com> Date: Sat, 22 Jun 2013 01:21:45 -0500 Message-ID: Subject: Re: sshd didn't run after upgrade to FreeBSD 8.4 From: Scot Hetzel To: Lee Dilkie Content-Type: text/plain; charset=ISO-8859-1 Cc: Kimmo Paasiala , Steven Hartland , Miroslav Lachman <000.fbsd@quip.cz>, freebsd-stable Stable X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Jun 2013 06:21:46 -0000 On Thu, Jun 20, 2013 at 4:28 AM, Lee Dilkie wrote: > > On 6/19/2013 8:24 PM, Kimmo Paasiala wrote: >> Ok, this is crazy. If you put one space after the VersionAddendum >> keyword you get exactly what you want, an empty VersionAddendum >> string. If there's no space but a newline right after the >> VersionAddendum keyword, sshd(8) complains about the line and refuses >> to start. So this is ok (without the single quotes, they are just to >> show the endings of the lines): >> >> 'VersionAddendum ' >> >> But this is not: >> >> 'VersionAddendum' >> >> What are the OpenSSH devs thinking? >> >> -Kimmo > > I'd call it a bug. > crypto/openssh/servconf.c 1553 case sVersionAddendum: 1554 if (cp == NULL) 1555 fatal("%.200s line %d: Missing argument.", filename, 1556 linenum); 1557 len = strspn(cp, WHITESPACE); 1558 if (*activep && options->version_addendum == NULL) { 1559 if (strcasecmp(cp + len, "none") == 0) 1560 options->version_addendum = xstrdup(""); 1561 else if (strchr(cp + len, '\r') != NULL) 1562 fatal("%.200s line %d: Invalid argument", 1563 filename, linenum); 1564 else 1565 options->version_addendum = xstrdup(cp + len); 1566 } 1567 return 0; Looks like if you specify: VersionAddendum none it won't display the additional info. -- DISCLAIMER: No electrons were maimed while sending this message. Only slightly bruised.