Date: Wed, 18 Jan 2023 08:47:56 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: rgrimes@freebsd.org Cc: Cy Schubert <Cy.Schubert@cschubert.com>, Juraj Lutter <otis@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1d577bedbae8 - main - unbound: Fix config file path Message-ID: <20230118164756.84556148@slippy.cwsent.com> In-Reply-To: <202301181645.30IGj4Ra010783@gndrsh.dnsmgr.net> References: <202301181645.30IGj4Ra010783@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <202301181645.30IGj4Ra010783@gndrsh.dnsmgr.net>, "Rodney W. Grimes" writes: > > > In message <202301181551.30IFpbRu010474@gndrsh.dnsmgr.net>, "Rodney W. > > > Grimes" > > > writes: > > > > [ Charset UTF-8 unsupported, converting... ] > > > > > > > > > > > > > > > > On 18 Jan 2023, at 16:34, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.n > et> wr > > > > ote: > > > > > > > > > > > > No, otis fixed it thus: > > > > > > -#define CONFIGFILE "/usr/local/etc/unbound/unbound.conf" > > > > > > +#define CONFIGFILE "/var/unbound/unbound.conf" > > > > > > > > > > > > > > > > > > > > > > I am suggesting that it should be > > > > > > #define CONFIGFILE "/etc/unbound/unbound.conf" > > > > > > > > > > > > ALL base system configuration files *should* be relative to /etc, n > ot /va > > > > r. > > > > > > > > > > > > > > > > Would this need any mtree changes or similar? > > > > > > > > No, /etc/unbound is a symbolic link already installed by the build syst > em, > > > > and /var/unbound is already a directory, again, installed by the build > system > > > > . > > > > > > > > This is a one line change that actually makes the /etc/unbound link wor > k > > > > correctly, without this change the binary has a hard coded path that ig > nores > > > > the > > > > /etc/unbound symbolic link and requires a recompile if I want to move > > > > things around, or maintanance of 2 symbolic links. > > > > > > > > Personally I dont see *why* unbound has a /var/unbound directory, can > > > > someone tell me why that was done? Is this some attempt and maintainin > g > > > > read only root? Does unbound scribble in the config directory, or > > > > is this simply mirroring some of the stuff that bind did? > > > > > > I see why it does this. Looking at usr.sbin/unbound/setup/local-unbound-s > etu > > > p.sh, it installs its config files in $workdir. Looking at git log > > > 49cede74eecf4 (SVN r255809), the last paragraph in the commit log entry > > > says: > > > > > > Note that these scripts place the unbound configuration files in > > > /var/unbound rather than /etc/unbound. This is necessary so that > > > unbound can reload its configuration while chrooted. We should > > > probably provide symlinks in /etc. > > Hang on a second... where is unbound chrooted to? If it is chrooted > to /var/unbound would it not then look for /var/unbound/var/unbound/unbound.c > onf? > > I got a feeling something is not well thought out here... Probably and it needs someone to investigate and possibly fix. I can put this on my todo list. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org e^(i*pi)+1=0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20230118164756.84556148>