From owner-freebsd-chat@FreeBSD.ORG  Thu Dec 30 02:16:43 2004
Return-Path: <owner-freebsd-chat@FreeBSD.ORG>
Delivered-To: freebsd-chat@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2690116A4CE
	for <freebsd-chat@freebsd.org>; Thu, 30 Dec 2004 02:16:43 +0000 (GMT)
Received: from pi.codefab.com (pi.codefab.com [199.103.21.227])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B138843D2F
	for <freebsd-chat@freebsd.org>; Thu, 30 Dec 2004 02:16:42 +0000 (GMT)
	(envelope-from cswiger@mac.com)
Received: from [192.168.1.3] (pool-68-160-208-232.ny325.east.verizon.net
	[68.160.208.232])
	by pi.codefab.com (8.12.11/8.12.11) with ESMTP id iBU2GRm7039817
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 29 Dec 2004 21:16:29 -0500 (EST)
Message-ID: <41D36550.4080900@mac.com>
Date: Wed, 29 Dec 2004 21:17:52 -0500
From: Chuck Swiger <cswiger@mac.com>
Organization: The Courts of Chaos
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.7.3) Gecko/20040910
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Joshua Lokken <joshua.lokken@gmail.com>
References: <bc5b638504122913577a3faec1@mail.gmail.com>
	<41D35547.5070105@mac.com> <bc5b63850412291803491bc14e@mail.gmail.com>
In-Reply-To: <bc5b63850412291803491bc14e@mail.gmail.com>
X-Enigmail-Version: 0.89.5.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=1.8 required=5.5 tests=RCVD_IN_NJABL_DUL,
	RCVD_IN_SORBS_DUL autolearn=disabled version=3.0.1
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.0.1 (2004-10-22) on pi.codefab.com
cc: freebsd-chat@freebsd.org
Subject: Re: less -f
X-BeenThere: freebsd-chat@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Non technical items related to the community
	<freebsd-chat.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-chat>,
	<mailto:freebsd-chat-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-chat>
List-Post: <mailto:freebsd-chat@freebsd.org>
List-Help: <mailto:freebsd-chat-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-chat>,
	<mailto:freebsd-chat-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Dec 2004 02:16:43 -0000

Joshua Lokken wrote:
> On Wed, 29 Dec 2004 20:09:27 -0500, Chuck Swiger <cswiger@mac.com> wrote:
[ ... ]
>>You're right, the manpage says and what the program actually does contradict
>>each other.  Consider the following change to /usr/src/contrib/less:
>>
>>--- filename.c~ Thu Jun 29 21:03:08 2000
>>+++ filename.c  Wed Dec 29 20:04:06 2004
>>@@ -954,10 +954,14 @@
>>        {
>>                static char is_dir[] = " is a directory";
>>
>>-               m = (char *) ecalloc(strlen(filename) + sizeof(is_dir),
>>-                       sizeof(char));
>>-               strcpy(m, filename);
>>-               strcat(m, is_dir);
>>+                if (force_open) {
>>+                    m = NULL;
>>+                } else {
>>+                    m = (char *) ecalloc(strlen(filename) + sizeof(is_dir),
>>+                                         sizeof(char));
>>+                    strcpy(m, filename);
>>+                    strcat(m, is_dir);
>>+                }
>>        } else
>>        {
> 
> Is this something that warrants a send-pr?  I've never used the 
> tool, and don't want to generate needless problem reports.
> What's the best way to handle it?  Thanks for any advice.

I have forwarded your problem description and the patch on to 
<bug-less@gnu.org>, so it can be considered by the author of less.

It might be reasonable to send-pr this as well, if you would like to see 
FreeBSD adopt the fix in a shorter timeframe.

-- 
-Chuck